Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Troubleshooting slow file inventory job #1328

Merged
merged 3 commits into from
Feb 26, 2025
Merged

Troubleshooting slow file inventory job #1328

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d0ceb0f
Add timing information to the file inventory job
hectorcorrea Feb 26, 2025
9f43d6c
Merge branch 'main' into 1274-inventory-slow
hectorcorrea Feb 26, 2025
536d0e6
Display the total time in addition to the time for each iteration
hectorcorrea Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions app/models/project.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,17 +281,25 @@ def file_list_to_file(session_id:, filename:)
query_req = Mediaflux::QueryRequest.new(session_token: session_id, collection: mediaflux_id, deep_search: true, aql_query: "type!='application/arc-asset-collection'")
iterator_id = query_req.result

start_time = Time.zone.now
prefix = "file_list_to_file #{session_id[0..7]} #{self.metadata_model.project_id}"
log_elapsed(start_time, prefix, "STARTED")

File.open(filename, "w") do |file|
page_number = 0
# file header
file.write("ID, PATH, NAME, COLLECTION?, LAST_MODIFIED, SIZE\r\n")
loop do
iterator_start_time = Time.zone.now
page_number += 1
iterator_req = Mediaflux::IteratorRequest.new(session_token: session_id, iterator: iterator_id, size: 1000)
iterator_resp = iterator_req.result
log_elapsed(iterator_start_time, prefix, "FETCHED page #{page_number} from iterator")
lines = files_from_iterator(iterator_resp)
file.write(lines.join("\r\n") + "\r\n")
break if iterator_resp[:complete] || iterator_req.error?
end
log_elapsed(start_time, prefix, "ENDED")
end

# Destroy _after_ fetching the results from iterator_req
Expand Down Expand Up @@ -332,4 +340,10 @@ def project_directory_pathname
def safe_name(name)
Project.safe_name(name)
end

def log_elapsed(start_time, prefix, message)
elapsed_time = Time.zone.now - start_time
timing_info = "#{format('%.2f', elapsed_time)} s"
Rails.logger.info "#{prefix}: #{message}, #{timing_info}"
end
end