Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ffi and JS wasm package #8

Merged
merged 13 commits into from
Jan 22, 2025
Merged

Add ffi and JS wasm package #8

merged 13 commits into from
Jan 22, 2025

Conversation

SHAcollision
Copy link
Collaborator

No description provided.

@SHAcollision SHAcollision added the enhancement New feature or request label Jan 11, 2025
@SHAcollision SHAcollision self-assigned this Jan 11, 2025
@SHAcollision
Copy link
Collaborator Author

SHAcollision commented Jan 21, 2025

@tipogi @amirRamirfatahi IMO this works and we can merge. Yet there is many caveats:

  • We have not yet settled for ffi or oop for the wasm. All ffi functions exist, but only PubkyAppUser uses OOP. Ideally we use OOP as interface in JS as well, however the final decision should be taken as we incorporate this library into the client's /contexts/_pubky.tsx . The API of the wasm is probably far from ideal, it might not be fully functional.
  • Web tests are not comprehensive (I don't think we need them to be as long as unit tests are comprehensive).
  • The NPM package readme is TODO , it is not ready for release, but the readme should be written before releasing.

Overall there is still quite some work left to do, but until we can get to implement this WASM into our client, it's hard to settle for some decisions.

@SHAcollision SHAcollision merged commit f1c34f7 into main Jan 22, 2025
2 checks passed
@SHAcollision SHAcollision mentioned this pull request Jan 29, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants