Toolsocket updates #1031
Toolsocket updates #1031
Conversation
dangond-ptc
commented
Apr 2, 2024
dangond-ptc
commented
- Adapted codebase to use ToolSocket v2.0.0's API.
|
I'm still working on tracking down the cause of the failing tests. |
|
Ok, after much investigation: the current code passes all tests on a clean install with the right toolsocket dependency. The issues I was having are:
|
libraries/utilities.js
Outdated
| @@ -75,7 +75,7 @@ const {identityFolderName} = require('../constants.js'); | |||
| var hardwareIdentity = path.join(objectsPath, identityFolderName); | |||
|
|
|||
| let socketReferences = { | |||
| realityEditorUpdateSocketArray: null | |||
| realityEditorUpdateSocketSubscriptions: null | |||
| }; | |||
|
|
|||
| let ioReference = null; | |||
There was a problem hiding this comment.
Can drop this variable and its use in utilities.setup()
| for (var thisEditor in realityEditorSocketArray) { | ||
| realityEditorSocketArray[thisEditor].forEach((thisObj) => { | ||
| if (typeof sourceSocketID !== 'undefined' && thisEditor === sourceSocketID && msgContent.object === thisObj.object && msgContent.frame === thisObj.frame) { | ||
| function sendMessageToEditors(msgContent, sourceSocket) { |
There was a problem hiding this comment.
Great improvement in readability!
|
(fix lint errors before merging) |
server.js
Outdated
| const subscriptions = []; | ||
| subscriptions.socket = socket; | ||
| realityEditorSocketSubscriptions.push(subscriptions); |
There was a problem hiding this comment.
Little bit confused about adding a socket property to an array, rather than using an object, is there a reason to structure it like this? (I'm not always up-to-date with clean coding conventions so I figure you have a valid reason, just curious)
There was a problem hiding this comment.
Looking at it now, I cannot come up with a good answer for this. I'll push a commit with a more sensible arrangement!
| ```bash | ||
| git clone --recurse-submodules https://github.com/ptcrealitylab/vuforia-spatial-edge-server.git | ||
| cd vuforia-spatial-edge-server | ||
| ./scripts/ci.sh | ||
| ``` |
There was a problem hiding this comment.
Thanks for updating the README, too!
|
@benptc Added a new commit regarding the socket property on the arrays. Lmk if that's better and looks good! |
