Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Builder: Electra #14344
Builder: Electra #14344
Changes from all commits
d0522ac
9269e0e
1ed404c
592a45a
512e388
bfae0ca
d8b98d7
dbc55c9
2521755
9c8d26e
734ef94
066ce6a
67235fb
6d580ec
c67df35
6d1a9fa
d5f8e02
2c907b2
289bb52
1c4be98
45c1d0b
c1a93d8
802a68b
0aae98d
1adc957
759b819
35e8541
a5cea41
9cdb111
b409a59
6c6b582
c5e8c82
174ba31
504db9f
4c2dbbb
add6015
3982901
91aa1b3
c0d01ea
8cef6df
a47bd35
e6a404e
89b8358
3a837b0
b7d6bcd
96ed501
e85d6e7
18738bf
4ac326e
46c55fc
6277a1b
1e74eeb
70ff336
2726f7a
5bbbad6
1cd3a71
cfd65c0
fbf7aae
e0c5034
6ec4a0f
6595008
b8aa910
2a29e0f
08def54
03f5754
7ab30bd
40c180e
f9483ef
2ac5089
ac64d37
73d2b5b
ab16642
4c40f18
15199e5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we make this type of comment here instead of leaving a real valid comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's been this way for the entire file, was supposed to mean it's self explanatory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should i add any more kinds of tests?