Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added navbar and footer #18

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

sharadhih
Copy link

@sharadhih sharadhih commented Dec 9, 2024

🚀 Pull Request Overview

Description

Added the Navbar and footer.
I was not sure about what color to put for the Navbar.

closes issue #4

Open Source @@programs

Are you associated with any open source programs (like KWoC, GSSoC etc)? Do mention it here.

KWoC

(If not, remove this part of the PR)


✅ Checklist:

  • My code adheres to the code style of this project.
  • I have run the appropriate tests for this change.
  • I have updated the documentation (if needed).
  • My PR references any relevant issues (if applicable).
  • Breaking changes?

@sharadhih
Copy link
Author

@prrockzed please review

@prrockzed
Copy link
Owner

Is everything working fine? Also please give some screenshots on how the page looks.

@sharadhih
Copy link
Author

This is how the page looks:
Screenshot 2024-12-16 184941

@ThePhoenix08 ThePhoenix08 mentioned this pull request Dec 18, 2024
8 tasks
Copy link
Owner

@prrockzed prrockzed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @sharadhih, will you please pull the new changes to accomodate with the updated code(resolve all merge conflicts). Also, don't you think that what you have as navbar and footer looks very weird. No padding between the board and the navbar and footer. The color of the navbar also looks a bit off. The logo can't be seen too. Please see to these suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants