Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace black with ruff, now linting imports so removed unused from requirements.txt #90

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

nateinaction
Copy link
Member

@nateinaction nateinaction commented Jan 10, 2025

Summary

Only human made changes are in the requirements.txt and the pre-commit-hook.yaml. Everything else is automated.

I replaced black linter with ruff which is faster and is capable of linting imports 🙏 which is something I have and love in my main language, golang.

Testing

Tested on main board of behavioral changes

Copy link
Contributor

@Alandlt15 Alandlt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this works. I created a local branch off main, and merged it into add-ruff-2 branch. Got this output:

image

Also tested on the board and it runs good.

@nateinaction nateinaction merged commit fc514a3 into main Jan 10, 2025
3 checks passed
@nateinaction nateinaction deleted the add-ruff-2 branch January 10, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants