multiBitFlag rollover to 0 once max is reached #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unction was used to make it more streamlined.
Closed
blakejameson
reviewed
Jan 9, 2025
nateinaction
changed the title
Co-authored-by: Alan De La Torre <[email protected]>
…BitFlag in line 85. It tries to type hint during an assignment. Removed : multiBitFlag
nateinaction
approved these changes
Jan 18, 2025
This was referenced Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
multiBitFlagclass is capable of counting from 0 to the maximum value of the number of bits requested. Once at the maximum value it would not change if incremented.This PR changes the behavior so that the
multiBitFlagclass always rolls over to 0 after reaching its maximum. We have checked the variables assigned as themultiBitFlagclass and believe this is not a breaking change. It's different behavior that we need to expect when reading satellite logs but no functionality should break.