Add more fields in messages #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrunner
force-pushed
the
improve-messages
branch
3 times, most recently
from
87bfa35 to
2669de0
Compare
carlio
reviewed
Jan 19, 2025
| ), | ||
| message_str, | ||
| doc_url=message.get("url"), | ||
| is_fixable=bool((message.get("fix") or {}).get("applicability") in ("safe", "unsafe")), |
There was a problem hiding this comment.
I think this could be a bit cleaner -
message.get("fix", {}) instead of message.get("fix") or {}
but also moving the whole thing onto a separate line just to make it clearer
There was a problem hiding this comment.
Your proposition is my initial code, but it's not working because fix is not missing but is None!
|
Mild nitpick above but otherwise seems good to me |
sbrunner
force-pushed
the
improve-messages
branch
from
2669de0 to
4d4f984
Compare
Pierre-Sassoulas
approved these changes
Jan 19, 2025
sbrunner
force-pushed
the
improve-messages
branch
from
4d4f984 to
69fd014
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add more fields in the messages
Related Issue
#708
Motivation and Context
Have more information useful to implement a VS Code extension to display the error in the IDE.
Types of changes