Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Codebook.value_map fn and iterator #147

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

BaxterEaves
Copy link
Contributor

Allows pylace users to pluck out the value map from the codebook and iterate over the values

@BaxterEaves BaxterEaves requested a review from Swandog November 2, 2023 19:41
@BaxterEaves BaxterEaves requested a review from a team as a code owner November 2, 2023 19:41
Copy link
Contributor

@schmidmt schmidmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good.

Copy link
Contributor

@Swandog Swandog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Though save yourself a step and update the CHANGELOG now.

@BaxterEaves BaxterEaves merged commit 645866e into release/0.5.0 Nov 14, 2023
@BaxterEaves BaxterEaves deleted the feature/expose-value-map branch November 14, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants