feat: allow module-qualified labels in generator.yml #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astralblue
force-pushed
the
allow_module_name_in_generator_yml
branch
from
8a8a94f to
4b95b09
Compare
Currently, some labels such as ifName and ifDescr are defined in multiple modules and must be specified using OID. This patch avails such OIDs under both its bare label and module-qualified labels, e.g. both "ifName" and "IF-MIB::ifName". Signed-off-by: Eugene Kim <[email protected]> Signed-off-by: Eugene Kim <[email protected]>
astralblue
force-pushed
the
allow_module_name_in_generator_yml
branch
from
4b95b09 to
ba7028d
Compare
astralblue
changed the title
SuperQ
approved these changes
Jan 7, 2025
bastischubert
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, some labels such as
ifNameandifDescrare defined in multiple modules and must be specified using OID. This patch avails such OIDs under both its bare label and module-qualified labels, e.g. bothifNameandIF-MIB::ifName.@bastischubert could you please take a look?