Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

organizeOutputBy=Patient query parameter #55

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

elsaperelli
Copy link
Collaborator

@elsaperelli elsaperelli commented Feb 10, 2025

Summary

This PR reworks the $export operation _bySubject=Patient query parameter to align with the Argonaut Bulk Data Access IG's organizeOutputBy query parameter.

New behavior

The organizeOutputBy query parameter is now implemented for resourceType Patient. Only organizeOutputBy=Patient is implemented. This query parameter works for all $export types- system-level, Patient, and Group. Also removes the _bySubject=Patient functionality.

Code changes

  • README.md - replaces _bySubject query parameter with organizeOutputBy
  • src/services/export.service.js - _bySubject -> organizeOutputBy
  • test/services/export.service.test.js - adds unit tests
  • test/util/exportToNDJson.test.js - remove test relating to _bySubject

Testing guidance

  • npm run check
  • npm run start
  • Use the attached Insomnia collection for testing.
  • In addition to the Insomnia collection, use the bulk-export-app's organizeOutputBy=Patient UI switch:
  • Make sure all references to _bySubject have been removed

organizeOutputByTests.json

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
74.24% (-1.39% 🔻)
562/757
🟡 Branches
60.67% (-2.66% 🔻)
199/328
🟡 Functions
73.33% (-2.5% 🔻)
88/120
🟡 Lines
74.46% (-1.41% 🔻)
554/744
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / export.service.js
85.71% (-0.19% 🔻)
79.55% (-0.45% 🔻)
94.12%
85.31% (-0.2% 🔻)
🟡
... / exportToNDJson.js
70.53% (-5.26% 🔻)
48.24% (-9.41% 🔻)
63.89% (-8.33% 🔻)
71.2% (-5.43% 🔻)

Test suite run success

95 tests passing in 8 suites.

Report generated by 🧪jest coverage report action from 9690d38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant