Fix #44: allow more than one try to fill username and password #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
| @@ -115,7 +115,7 @@ Vagrant.configure('2') do |config| | |||
| end | |||
| ``` | |||
|
|
|||
| If you do not provide credentials, you will be prompted for them in the "up process." | |||
| If you do not provide credentials, you will be prompted for them with maximum three attempts during the "vagrant up" process. | |||
|
@budhrg can you please rebase? |
|
@LalatenduMohanty Waiting for preeti to comment on doc side. Then I will rebase. |
|
@budhrg you should add acceptance test for this PR. |
|
Working on acceptance test now. |
|
@LalatenduMohanty Create issue #106. Could you verify and merge it? |
|
LGTM. |
|
merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #44
Patched gem to try:- https://www.dropbox.com/s/dahxpg8is07wbwm/vagrant-registration-1.2.4.dev.gem
Also displaying "Registration successful." message on successful registration.