-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic resources endpoints #319
Draft
Adam0Brien
wants to merge
32
commits into
project-kessel:main
Choose a base branch
from
Adam0Brien:dynamic-resources-poc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modify workflow to include configs
…into dynamic-resources-poc
…into dynamic-resources-poc
11 tasks
Adam0Brien
force-pushed
the
dynamic-resources-poc
branch
3 times, most recently
from
February 4, 2025 11:53
a5e6074
to
9d9b0d9
Compare
Can one of the admins verify this patch? |
jmelis
reviewed
Feb 6, 2025
@@ -15,6 +15,7 @@ COPY api ./api | |||
COPY cmd ./cmd | |||
COPY internal ./internal | |||
COPY main.go Makefile ./ | |||
COPY data/resources ./data/resources |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed extracting the resources to a separate image. Let's keep it here for now, until we have a use case to separate it! +1 to this
Adam0Brien
force-pushed
the
dynamic-resources-poc
branch
from
February 7, 2025 11:50
e207c85
to
930aee6
Compare
Adam0Brien
force-pushed
the
dynamic-resources-poc
branch
from
February 7, 2025 16:55
626983a
to
946cf36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Template:
Describe your changes
Create a k8s_ cluster
Create a k8s_ policy
Create a rhel_host
Create a notification integration
Error handling
If JSON data is missing the JSON_VALIDATOR will catch the missing data and tell the user:
Ticket reference (if applicable)
Fixes #
Checklist
Are the agreed upon acceptance criteria fulfilled?
Was the 4-eye-principle applied? (async PR review, pairing, ensembling)
Do your changes have passing automated tests and sufficient observability?
Are the work steps you introduced repeatable by others, either through automation or documentation?
The Changes were automatically built, tested, and - if needed, behind a feature flag - deployed to our production environment. (Please check this when the new deployment is done and you could verify it.)
Are the agreed upon coding/architectural practices applied?
Are security needs fullfilled? (e.g. no internal URL)
Is the corresponding Ticket in the right state? (should be on "review" now, put to done when this change made it to production)
For changes to the public API / code dependencies: Was the whole team (or a sufficient amount of ppl) able to review?