Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No FSTAR_HOME (for _taramana_cbor) #163

Closed
wants to merge 5 commits into from

Conversation

mtzguido
Copy link
Member

@mtzguido mtzguido commented Jan 8, 2025

EDIT: Probably the right thing is to take #162 and then merge master into _taramana_cbor (or rebase it). Keeping open as a draft anyway, since some of the changes are not there on master (e.g. pulse.Makefile does not exist).

Note: 3d itself also inspects this variable (it was inspecting
FSTAR_HOME before). It may be easier to remove this behavior and add a
flag, so the fstar used is explicit in the Makefiles.
@mtzguido mtzguido marked this pull request as draft January 11, 2025 00:26
@tahina-pro
Copy link
Member

Thanks a lot Guido! I replicated your changes into #155 (EverParse+Pulse) as db4cc1c, f394a53 and 5e572ee, and merged them into taramana_cbor as cf1ebb0

@tahina-pro tahina-pro closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants