Move security audit checks to a daily schedule [SAME VERSION] #264
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As part of check-rust workflow, we also run
cargo audit
to detect any security vulnerabilities in Akri's dependencies. This was added to catch newly added dependencies imposing security risks to Akri. However, we ended up with those checks blocking PRs & code merges because of existing dependencies being out of date or a new vulnerability is discovered in a version of a crate that Akri is already consuming, so this check ended up being very noisy and hence this PR.This change:
A v2 of this change would be to add another step in check-rust workflow to audit newly added dependencies. Another potential improvement is to attempt re-running the audit after a cargo update and in case that succeeds the workflow can kick off the autoupdate-dependencies workflow instead of sending an email to minimize manual intervention.
Note: The audit github action will create an issue when a vulnerability is detected. I'm not very happy with that as that is not a recommended/secure approach. Usually in the event a security vulnerability is detected in some codebase, it is best to fix asap rather than documenting it through issues where others become aware of that and can leverage to compromise the code. I opened an issue on audit-check and will investigate other github action options.
Special notes for your reviewer:
If applicable:
cargo fmt
)cargo build
)cargo clippy
)cargo test
)cargo doc
)./version.sh
)