Issue-3441-cleaning-assets #3442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am fixing a broken link that is blocking the build (see Issue #3443). The build checks indicate that various assets 'do not exist', but I believe this may be a temporary error, because those assets do exist (in this branch, at least). Hopefully these errors will disappear once the broken link is resolved. |
Update asset link
Add / preceding relative link to assets (line 416).
blank commit to relaunch build
undo blank commit
Update filepath
Update filepath (?)
try asset filepath again
Try asset filepath again
Fix filepath
…arkdown directory delete to test
Remove link to try to fix things for now
Remove link to try to fix things for now
Try relinking to asset
Try relinking to asset
remove link to asset...
Remove link to asset...
Try different asset format
Try different asset link format
Minor edit
|
Hello @anisa-hawes, I've checked through all the links in the EN and ES lessons. I only made one edit, which was to remove some leftover syntax from when we resolved the conflicts together. |
anisa-hawes
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Amazing, @charlottejmc! 💫
I have checked all the FR and PR asset links and everything works smoothly 🙌🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been working on sorting all the assets which were floating around the directory into dedicated lesson folders, then updating the links within the lessons to reflect the change.
Some notes:
python-lessonsandpython-es-lecciones. zipfolders as they were (floating), because I believe it may make more sense that way. Please let me know if you disagree!galdos_miau.txt: a copy of this file was already sorted intoen/sentiment-analysis-syuzhet. However, because the original lesson here is the ES versiones/analisis-de-sentimientos-r, I moved it to a new folder under that slug. I then deleted the extra copy which was just floating.scissorsandpaste-master.zip: no file under this name was use in any of our lessons. However, it is identical tomaster.zip, which was already sorted in theen/transforming-xml-with-xslfolder.Closes #3441
Checklist
Closes #ISSUENUMBERto your summary above[ ] if the text needs to be translated, please follow the translation request guidelines, then assign the relevant language team(s) as "Reviewers" and tag both the team as well as the managing editor in your PR.