Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 3138 #3139

Merged
merged 6 commits into from
Jan 3, 2024
Merged

Issue 3138 #3139

merged 6 commits into from
Jan 3, 2024

Conversation

charlottejmc
Copy link
Contributor

@charlottejmc charlottejmc commented Jan 3, 2024

I have numbered the figures in lesson Computer Vision for the Humanities: An Introduction to Deep Learning for Image Classification (Part 1 + 2). I have also updated the file names in the image directories and within the text itself.

Closes #3138

Checklist

  • Assign yourself in the "Assignees" menu
  • Add the appropriate "Label"
  • If this PR closes an Issue, add the phrase Closes #ISSUENUMBER to your summary above
  • Ensure the status checks pass: if you have difficulty fixing build errors, please contact our Publishing Manager @anisa-hawes
  • Check the Netlify Preview: navigate to netlify/ph-preview/deploy-preview and click 'details' (at right)
  • Assign at least one individual or team to "Reviewers"
    • [ ] if the text needs to be translated, please follow the translation request guidelines, then assign the relevant language team(s) as "Reviewers" and tag both the team as well as the managing editor in your PR.

Number figures and update the links to match the renamed files, according to our image naming convention
Files have been renamed according to our image naming convention. `metrics_report.png` has been deleted as it was not used in the lesson.
Number figures and update the links to match the renamed files, according to our image naming convention
Copy link
Contributor

@anisa-hawes anisa-hawes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @charlottejmc! This makes it much simpler for us to manage the directory when it begins to include some translated images (and helps us keep things consistent with ph-submissions!)

@charlottejmc charlottejmc merged commit 5b955ce into gh-pages Jan 3, 2024
6 checks passed
@charlottejmc charlottejmc deleted the Issue-3138 branch January 3, 2024 15:16
@anisa-hawes
Copy link
Contributor

Hello @hawc2. Tagging you here to keep you updated on a small adjustment we've made to computer-vision-deep-learning-pt1 and computer-vision-deep-learning-pt2.

The only visible change to the published lessons is that we've added Figure numbers to the captions. In the background, we've also renamed the image files, and updated the filenames in the liquid syntax accordingly. (This was prompted by some fiddly knots we've encountered with translations of this lesson which are in progress in ES and FR. Helps us to simplify things and avoid mistakes!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants