Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 3116 : Publish /en/lesson/interactive-visualization-with-plotly #3117

Merged
merged 9 commits into from
Dec 14, 2023

Conversation

anisa-hawes
Copy link
Contributor

@anisa-hawes anisa-hawes commented Dec 8, 2023

Preparing files for publication.

Closes #3116

Checklist

  • Assign yourself in the "Assignees" menu
  • Add the appropriate "Label"
  • If this PR closes an Issue, add the phrase Closes #ISSUENUMBER to your summary above
  • Ensure the status checks pass: if you have difficulty fixing build errors, please contact our Publishing Manager @anisa-hawes
  • Check the Netlify Preview: navigate to netlify/ph-preview/deploy-preview and click 'details' (at right)
  • Assign at least one individual or team to "Reviewers"
    • [ ] if the text needs to be translated, please follow the translation request guidelines, then assign the relevant language team(s) as "Reviewers" and tag both the team as well as the managing editor in your PR.

Add bio : Grace Di Méo
Add markdown file (adjusting all /assets and /images links to be relative links).
@anisa-hawes anisa-hawes self-assigned this Dec 8, 2023
Update references to previous figure numbers in captions for Figures 15, 16, 17.
@anisa-hawes
Copy link
Contributor Author

Hello @hawc2.

I’ve staged interactive-visualization-with-plotly for publication. You can read it through in Preview and let me know if you note anything which you'd like to adjust.

I'm tagging @scottkleinman here too. I've checked through and I think the interactive html plots are displaying + behaving as we intended, but I appreciate your perspective on this!

If you're both happy, we can publish this lesson next Wednesday when our colleagues at Sussex will be around to activate our DOI, and Charlotte & I can launch the promotions on social media.

Thank you,
A.

@hawc2
Copy link
Contributor

hawc2 commented Dec 8, 2023

@anisa-hawes this looks pretty perfect to me. I'm happy to report I was able to comfortably read this whole lesson on my phone, even all the interactive plots worked well on mobile.

@anisa-hawes anisa-hawes requested a review from hawc2 December 11, 2023 12:53
@anisa-hawes
Copy link
Contributor Author

anisa-hawes commented Dec 11, 2023

Hello @hawc2.

Thank you for this feedback!

Scott has written to me separately to confirm that he's read the lesson as staged here in Jekyll, and is happy with the functionality and rendering of all the plots.

I'll request your review here now.

As explained above, I'd like to wait to publish this on Wednesday when we can also activate the DOI and launch promotion.

Thank you. A.

@hawc2
Copy link
Contributor

hawc2 commented Dec 11, 2023

@anisa-hawes I made one edit I should've caught earlier, I changed most occurrences of "tutorial" to "lesson". Should be good to go

@anisa-hawes anisa-hawes merged commit 8c5658c into gh-pages Dec 14, 2023
4 checks passed
@anisa-hawes anisa-hawes deleted the Issue-3116 branch December 14, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preparing to publish new EN lesson interactive-visualization-with-plotly
2 participants