Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update topics.yml #3112

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Update topics.yml #3112

merged 1 commit into from
Dec 7, 2023

Conversation

charlottejmc
Copy link
Contributor

@charlottejmc charlottejmc commented Dec 7, 2023

Add: - type: data-visualization

Closes #3111

Checklist

  • Assign yourself in the "Assignees" menu
  • Add the appropriate "Label"
  • If this PR closes an Issue, add the phrase Closes #ISSUENUMBER to your summary above
  • Ensure the status checks pass: if you have difficulty fixing build errors, please contact our Publishing Assistant @anisa-hawes
  • Check the Netlify Preview: navigate to netlify/ph-preview/deploy-preview and click 'details' (at right)
  • Assign at least one individual or team to "Reviewers"
    • if the text needs to be translated, please follow the translation request guidelines, then assign the relevant language team(s) as "Reviewers" and tag both the team as well as the managing editor in your PR.

Add data-visualization
@charlottejmc
Copy link
Contributor Author

Dear @jenniferisasi, @marie-flesch and @DanielAlvesLABDH,

May I ask if you could review my ES, FR and PT translation of a new topic: and description:?

- type: data-visualization
  displayname:
    en: "data visualization"
    es: "visualización de datos"
    fr: "visualisation de données"
    pt: "visualização de dados"
  description:
    en: "Lessons which teach the representation of data through common graphics."
    es: "Lecciones que enseñan a representar datos mediante gráficos comunes."
    fr: "Leçons qui enseignent la représentation de données à l'aide de graphiques communs."
    pt: "Lições que ensinam a representação de dados através de gráficos comuns."

You can add a comment here with your suggested changes, or edit the file directly in this branch.

Please note: this new topic will not show in the Netlify preview or on the live lesson indexes for each journal until it is included in at least one lesson’s YAML.

Thank you! ✨

Copy link
Contributor

@jenniferisasi jenniferisasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to see this as a topic! This sounds good in Spanish and I believe that it is correct also in Portuguese

@DanielAlvesLABDH
Copy link
Contributor

Yes, the Portuguese is totally fine. Thanks

@marie-flesch
Copy link
Contributor

The French translation is good too!

@charlottejmc
Copy link
Contributor Author

Thank you all for such swift replies!

@charlottejmc charlottejmc merged commit 1c6f20e into gh-pages Dec 7, 2023
5 checks passed
@charlottejmc charlottejmc deleted the Issue-3111 branch December 7, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new topic for our lesson directory
4 participants