Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 3441 #3442

Open
wants to merge 10 commits into
base: gh-pages
Choose a base branch
from
Open

Issue 3441 #3442

wants to merge 10 commits into from

Conversation

charlottejmc
Copy link
Contributor

@charlottejmc charlottejmc commented Jan 8, 2025

I've been working on sorting all the assets which were floating around the directory into dedicated lesson folders, then updating the links within the lessons to reflect the change.

Some notes:

  • I've left the python-lessons and python-es-lecciones . zip folders as they were (floating), because I believe it may make more sense that way. Please let me know if you disagree!
  • I deleted two files:
    • galdos_miau.txt: a copy of this file was already sorted into en/sentiment-analysis-syuzhet. However, because the original lesson here is the ES version es/analisis-de-sentimientos-r, I moved it to a new folder under that slug. I then deleted the extra copy which was just floating.
    • scissorsandpaste-master.zip: no file under this name was use in any of our lessons. However, it is identical to master.zip, which was already sorted in the en/transforming-xml-with-xsl folder.

Closes #3441

Checklist

  • Assign yourself in the "Assignees" menu
  • Add the appropriate "Label"
  • If this PR closes an Issue, add the phrase Closes #ISSUENUMBER to your summary above
  • Ensure the status checks pass: if you have difficulty fixing build errors, please contact our Publishing Manager @anisa-hawes
  • Check the Netlify Preview: navigate to netlify/ph-preview/deploy-preview and click 'details' (at right)
  • Assign at least one individual or team to "Reviewers"
    • [ ] if the text needs to be translated, please follow the translation request guidelines, then assign the relevant language team(s) as "Reviewers" and tag both the team as well as the managing editor in your PR.

@charlottejmc
Copy link
Contributor Author

charlottejmc commented Jan 8, 2025

I am fixing a broken link that is blocking the build (see Issue #3443). The build checks indicate that various assets 'do not exist', but I believe this may be a temporary error, because those assets do exist (in this branch, at least). Hopefully these errors will disappear once the broken link is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sorting floating assets into dedicated lesson folders
2 participants