Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove coord.Node type #59

Merged
merged 3 commits into from
Oct 9, 2023
Merged

chore: remove coord.Node type #59

merged 3 commits into from
Oct 9, 2023

Conversation

iand
Copy link
Contributor

@iand iand commented Oct 9, 2023

This PR removes coordt.Node which was created early in development. Originally query functions received this node interface with the intention that they could use it to interact directly with a discovered remote node. It is now redundant since query functions now only receive the node id,

As a side effect, fixes #58 since that code is no longer needed.

@iand iand merged commit 5e1dd09 into main Oct 9, 2023
@iand iand deleted the coordt-node-remove branch October 9, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Reuse NodeHandlers in GetClosestNodes
2 participants