Improve testability #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Postremus
force-pushed
the
better-testability
branch
from
e2315f0 to
9ac0465
Compare
now uses maven itf for integration tests, and makes most tests simple unit tests
Postremus
force-pushed
the
better-testability
branch
from
9ac0465 to
5e341a7
Compare
sepe81
reviewed
Dec 10, 2023
| @@ -61,7 +60,7 @@ public Void call() throws Exception { | |||
| InputStream in = new BufferedInputStream(new FileInputStream(source))) { | |||
| JasperCompileManager.compileReportToStream(in, out); | |||
| if (verbose) { | |||
| log.info("Compiling " + source.getName()); | |||
| LOGGER.info("Compiling " + source.getName()); | |||
There was a problem hiding this comment.
Maybe use "Parameterized Logging" for all changed or new loggers?
There was a problem hiding this comment.
Thanks for the review. Yes I agree. Now that we are using slf4j, lets also switch to parameterized logging. Follow up pr coming soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the main problems with the current tests is, they are not executable in idea.
This makes them pretty difficult to debug if anything fails.
Therefore, here is a rewrite of the tests.