Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update send_receive_data.md #1822

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Update send_receive_data.md #1822

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions doc/send_receive_data.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,14 @@ The application could combine `nb_bytes_ = 0` (no data to send now) and `fin = 1
if finished sending that stream. The stack will then send a stream data frame with
no content but the `FIN` bit set, marking the end of the stream.

The application could also set `is_still_active=1`, or call `picoquic_mark_active_stream`
from within the call back, which is equivalent. But that's a bit of a gamble.
The stack will try to fill the current packet with some other content,
The application could also set `is_still_active=1` from within the call back if more data is to be polled, e.g.:
~~~
/* Poll for data in the next callback */
(void)picoquic_provide_stream_data_buffer(context, 0, 0, 1);
~~~
It is to be noted that using mark_active_stream from within the callback is ambiguous, and may not behave the same way as `setting is_still_active=1`, as shown above, since it is not linked to the callback context.

When setting the is_still_active stream from within the callback, the stack will try to fill the current packet with some other content,
but will immediately repeat the callback when ready to send another packet.
That kind of "hyper active polling" may not be the best for performance, except in the
case when the application message does not fit in the length of the buffer, maybe
Expand Down Expand Up @@ -403,4 +408,4 @@ the application, and to delete them if the queue overflows.
## Receiving datagram data

The application will receive the callback `picoquic_callback_datagram` when a
datagram is received.
datagram is received.
Loading