h3zero get GET content types by path #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitema
approved these changes
Aug 7, 2024
|
I entered #1730 to capture the "query string" discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are currently playing with Chrome and the picoquicdemo as a server.
Currently, unless the
h3zero_server_default_pageis requested (stream_ctx->echo_size/length == 0), the content typeh3zero_content_type_text_plainis set in the response header for each GET request. Wouldn't it be possible to set the content type via extension?If I am correct,
h3zerodoes not currently support query strings. That's why I haven't added support for it at the moment. If desired, I will include this in another PULL request later.