Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serde is now a non-optional dependency #996

Merged
merged 6 commits into from
Apr 4, 2024

Conversation

cberkhoff
Copy link
Collaborator

Removed the enable-serde flag and made Serde a non-optional dependency. Removed the cfg attributes that depended on the feature since now the library is included by default.

Testing

Both unit tests and ./pre-commit pass.

closes #588

Removed the "enable-serde" flag and made Serde a non-optional dependency.
Removed the cfg attributes that depended on the feature since now the
library is included by default.
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 90.01%. Comparing base (fc791b2) to head (21a08b2).

Files Patch % Lines
ipa-core/src/bin/ipa_bench/models.rs 0.00% 5 Missing ⚠️
ipa-core/src/cli/noise.rs 0.00% 2 Missing ⚠️
ipa-core/src/helpers/mod.rs 75.00% 1 Missing ⚠️
ipa-core/src/protocol/mod.rs 50.00% 1 Missing ⚠️
ipa-core/src/protocol/step/compact.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #996      +/-   ##
==========================================
+ Coverage   89.71%   90.01%   +0.30%     
==========================================
  Files         169      168       -1     
  Lines       23029    22959      -70     
==========================================
+ Hits        20660    20667       +7     
+ Misses       2369     2292      -77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@akoshelev akoshelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks! The code coverage issues are probably coming from us not using these structs at all. Would you be able to test which ones are needed by simply deleting them and compiling the code? We may be able to clean up even more things

@cberkhoff
Copy link
Collaborator Author

I went over the classes that were flagged as part of the coverage check and they were either:
a) Not used anywhere in the code. I removed those classes in the last commits.
b) Tests where not exercising the classes for which I added serialization/deserialization. This issue is orthogonal to this PR and rather tackle that separately.

Copy link
Collaborator

@akoshelev akoshelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, will merge it tomorrow

@akoshelev akoshelev merged commit b0b700a into private-attribution:main Apr 4, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete "enable-serde" feature
2 participants