Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events and query structure definitions #27

Merged
merged 4 commits into from
May 26, 2022

Conversation

taikiy
Copy link
Contributor

@taikiy taikiy commented Apr 26, 2022

Quick implementation of source/trigger events and IPA query data models. Actual parameter types require further reviews but submitting the first try for PoC.

Copy link
Collaborator

@benjaminsavage benjaminsavage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this! A few suggestions.

src/helpers/models.rs Outdated Show resolved Hide resolved
src/helpers/models.rs Outdated Show resolved Hide resolved
src/helpers/models.rs Outdated Show resolved Hide resolved
src/helpers/models.rs Outdated Show resolved Hide resolved
src/helpers/models.rs Outdated Show resolved Hide resolved
src/helpers/models.rs Outdated Show resolved Hide resolved
src/helpers/models.rs Outdated Show resolved Hide resolved
src/helpers/models.rs Outdated Show resolved Hide resolved
src/helpers/models.rs Outdated Show resolved Hide resolved
@taikiy
Copy link
Contributor Author

taikiy commented May 10, 2022

@benjaminsavage Thanks for reviewing! Fixed the code accordingly.

src/helpers/models.rs Outdated Show resolved Hide resolved
src/helpers/models.rs Outdated Show resolved Hide resolved
src/helpers/models.rs Outdated Show resolved Hide resolved
src/helpers/models.rs Outdated Show resolved Hide resolved
src/helpers/models.rs Show resolved Hide resolved
src/helpers/models.rs Outdated Show resolved Hide resolved
@taikiy
Copy link
Contributor Author

taikiy commented May 25, 2022

@benjaminsavage I was offline for a several days last week. Updated the PR again. Thanks in advance!

Copy link
Collaborator

@benjaminsavage benjaminsavage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. Thank you for this!

src/helpers/models.rs Outdated Show resolved Hide resolved
@benjaminsavage benjaminsavage merged commit ec470f7 into private-attribution:main May 26, 2022
@taikiy taikiy deleted the payload branch June 20, 2022 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants