Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OPRF IPA code #1523

Merged
merged 10 commits into from
Jan 15, 2025
Merged

Conversation

akoshelev
Copy link
Collaborator

As we migrated everything to Hybrid, the old code is just a copy-paste and carries some dead weight we should avoid. There is a branch oprf-ipa that has everything if we ever need to pick up this code again.

Unfortunately we made quite a bit of shortcuts and there is currently no benchmark code for Hybrid

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.08%. Comparing base (afb5e48) to head (7fecafc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ipa-core/src/bin/report_collector.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1523      +/-   ##
==========================================
- Coverage   93.08%   92.08%   -1.01%     
==========================================
  Files         237      220      -17     
  Lines       44209    38237    -5972     
==========================================
- Hits        41153    35211    -5942     
+ Misses       3056     3026      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ipa-core/src/report/ipa.rs Outdated Show resolved Hide resolved
@akoshelev akoshelev merged commit a6140b6 into private-attribution:main Jan 15, 2025
13 checks passed
@akoshelev akoshelev deleted the remove-oprf-ipa branch January 15, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants