Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement protocol to create cross-shard coordinated randomness #1426

Merged

Conversation

akoshelev
Copy link
Collaborator

This protocol will generate random seeds using PRSS and then distribute those seeds to all shards. Every shard will initialize cross-shard PRSS from those seeds. Follows up on #1410.

This protocol will generate random seeds using PRSS and then distribute those seeds to all shards. Every shard will initialize cross-shard PRSS from those seeds
@eriktaubeneck
Copy link
Member

is this supposed to integrate with ShardBinding::cross_shard_prss? If so, it's not obvious how that happens.

otherwise, looks good (other than a test issue to resolve)

@akoshelev
Copy link
Collaborator Author

akoshelev commented Nov 12, 2024

Is this supposed to integrate with ShardBinding::cross_shard_prss? If so, it's not obvious how that happens.

yes, this will be used in real world implementation to initialize PRSS instances on different shards. I am working on sharded shuffle implementation that will make use of it

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 96.38554% with 6 lines in your changes missing coverage. Please review.

Project coverage is 93.40%. Comparing base (e6e08af) to head (619b442).
Report is 36 commits behind head on main.

Files with missing lines Patch % Lines
ipa-core/src/helpers/cross_shard_prss.rs 90.32% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1426      +/-   ##
==========================================
+ Coverage   93.29%   93.40%   +0.11%     
==========================================
  Files         224      227       +3     
  Lines       38602    39149     +547     
==========================================
+ Hits        36014    36569     +555     
+ Misses       2588     2580       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akoshelev akoshelev merged commit 63a40c2 into private-attribution:main Nov 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants