Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transposes for vectorized aggregation #1008

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

andyleiserson
Copy link
Collaborator

Add additional macros in transpose implementation, to reduce repetitive code

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 90.42553% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 90.46%. Comparing base (28411cd) to head (aa1554d).
Report is 7 commits behind head on main.

Files Patch % Lines
ipa-core/src/secret_sharing/vector/transpose.rs 90.10% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1008      +/-   ##
==========================================
- Coverage   90.61%   90.46%   -0.15%     
==========================================
  Files         167      167              
  Lines       23549    23806     +257     
==========================================
+ Hits        21339    21537     +198     
- Misses       2210     2269      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Add additional macros in transpose implementation, to reduce repetitive code
@andyleiserson
Copy link
Collaborator Author

I removed the special transpose for aggregation because that was the bulk of the missing coverage and enough to get over the threshold. The coverage situation will improve once the vectorized aggregation is added.

@akoshelev
Copy link
Collaborator

I trust that you do the right thing here, but I also find it very hard to comprehend what is going on there. Having no concrete suggestions how to improve things, my vote is to ship it

@andyleiserson andyleiserson merged commit eaf1b82 into private-attribution:main Apr 17, 2024
11 checks passed
@andyleiserson andyleiserson deleted the transpose branch April 17, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants