Use BytesStream inside Transport trait
#1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is to unify stream handling between in-memory and real-world implementations. Before, in memory streams yielded `Vec<u8>` and HTTP streams operated on `Result<Bytes, _>`. This discrepancy required us to build a compatibility layer, and it makes sense now to unify both implementations. The main motivator for this change is to be able to use `RecordsStream` inside shard receivers - `UnorderedReceiver` use case fits MPC model well, but is clunky to use inside shard channels.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1001 +/- ##
==========================================
- Coverage 90.64% 90.59% -0.05%
==========================================
Files 167 167
Lines 23541 23548 +7
==========================================
- Hits 21338 21334 -4
- Misses 2203 2214 +11 ☔ View full report in Codecov by Sentry. |
andyleiserson
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to unify stream handling between in-memory and real-world implementations. Before, in memory streams yielded
Vec<u8>and HTTP streams operated onResult<Bytes, _>.This discrepancy required us to build a compatibility layer, and it makes sense now to unify both implementations.
The main motivator for this change is to be able to use
RecordsStreaminside shard receivers -UnorderedReceiveruse case fits MPC model well, but is clunky to use inside shard channels - we always receive items in a pure streaming fashion instead.