rules: Fix override false positive

Fix #557 Signed-off-by: Vyacheslav Yurkov <[email protected]>
priv-kweihmann · Apr 2, 2024 · 0aedbde · 0aedbde
1 parent 5925f45
commit 0aedbde
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/oelint_adv/rule_base/rule_vars_variable_override.py b/oelint_adv/rule_base/rule_vars_variable_override.py
@@ -17,7 +17,7 @@ def check(self, _file: str, stash: Stash) -> List[Tuple[str, int, str]]:
         res = []
         _all: List[Variable] = list(x for x in stash.GetItemsFor(filename=_file, classifier=Variable.CLASSIFIER))  # noqa: C400
         for v in {x.VarName for x in _all}:
-            items = [x for x in _all if x.VarName == v]
+            items = [x for x in _all if x.VarName == v and x.IsImmediateModify()]
             items = sorted(items, key=lambda x: x.Line, reverse=False)
             for sub in [x.SubItem for x in items]:
                 # Get all entries but not the only that do immediate expansion,

diff --git a/tests/test_class_oelint_var_override.py b/tests/test_class_oelint_var_override.py
@@ -96,6 +96,14 @@ def test_bad(self, input_, id_, occurrence):
                                      FILESEXTRAPATH_append := ":b"
                                      ''',
                                  },
+                                 {
+                                     'oelint_adv_test.bb':
+                                     '''
+                                     PACKAGECONFIG = "a b c"
+                                     PACKAGECONFIG:remove = "a"
+                                     PACKAGECONFIG:remove = "b"
+                                     ''',
+                                 },
                              ],
                              )
     def test_good(self, input_, id_, occurrence):