Alter field #146
Merged
Alter field #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serendipity-crypto
force-pushed
the
alter_field
branch
from
a510aff to
bd9bfeb
Compare
| @@ -2,7 +2,7 @@ use crate::{ | |||
| extension::TwoAdicField, field::Field, modulus::to_monty, BabyBear, BinomialExtensionField, | |||
| BinomiallyExtendable, HasTwoAdicBionmialExtension, | |||
| }; | |||
| use num_traits::{One, Zero}; | |||
| use num_traits::{ConstOne, ConstZero}; | |||
There was a problem hiding this comment.
Can we keep using One,Zero? otherwise, the follow up PRs need to change back and forth.
There was a problem hiding this comment.
Is there any Field not suitable with ConstOne or ConstZero?
There was a problem hiding this comment.
not really, just because these things are changed back and forth a lot of times.
There was a problem hiding this comment.
ConstOne and ConstZero are better. We will implement Field with them.
Yes. |
xiangxiecrypto
approved these changes
Sep 24, 2024
xiangxiecrypto
added a commit
that referenced
this pull request
Oct 30, 2024
* range check without optimizations and random test * fmt * add random test * fmt * clippy * comments * record * backup * logup * fmt * fmt * comment * lookup num can be arbitrary integer * fiat shamir randomness * enable more actions for check (#133) * enable more actions for check * disable `asm` feature for `sha2` * update `bytemuck` and `criterion` * cfg `sha2` * move batch_inverse to util * reconstruct BitDecomposition * finish bit decomp * unify transcript in FF and EF * snarks for bit decomposition * reconstruct addition in Zq * add snarks for addition in zq * general lookup * finish iop for ntt * snarks for ntt * add EF for RoundIOP * snarks for round * range check without optimizations and random test * fmt * add random test * fmt * clippy * comments * record * backup * logup * fmt * fmt * comment * lookup num can be arbitrary integer * fiat shamir randomness * move batch_inverse to util * general lookup * fix * reconstruct RLWE * RGSW * reconstruct snarks for RLWE * RGSW * fmt * add RLWE * RGSW example * delete dead code * rename * rename * reconstruct Accumulator * check equality relations among ACC * add snarks for ACC * fmt * check & clippy * fix * fix BabyBear * rewrite zq to rQ * fmt * for merge * snarky lookup * fix * fix * add example for zq to rq * optimize with lookup * rename to floor * add round * sumcheck paralleled, >2x improved * optimize evaluate_ext * optimize acc evaluate_ext * minor for lookup * mle from poly * revise ntt * optimized with hashmap * fmt & clippy & test * clippy * fix fmt/clippy/typo * typo clippy * Remove `check-msrv` (#150) * remove `check-msrv` * remove `typos` * Alter field (#146) * remake `primitive` * add `ExpPowOf2Reduce` ops * add `NegOne` and `ConstNegOne` trait * clippy * typos * improve `CarryingMul` and `WideningMul` * file rename * add pcs batch open and verify * minor * add assertion * minor * update lookup * minor * minor * refine lookup * pcs for extension field polynomial * clippy * finish lookup * refine bit decomposition types * refine bit decomposition * refine addition in Zq * refine lookup * refine bit decomp * remove lookup in addition in zq and refine * refine ntt names * refine ntt-bare * ntt refine first version * refine proof struct * refine instance info struct * refine ntt * refine ntt * refine ntt example * combine ntt normal and reverse order * refine ntt in normal and reverse order * refine floor * refine round * rename zq_to_rq to lift * refine lift * refine extenal product naming * rename * refine external product * refine EP step 2 * refine * refine external product * refine acc * Revert "refine acc" This reverts commit 88ab2fc. * simplify add struct * refine acc complete * refactor * refactor * optimize acc proving time * remove dead code * remove ds_store * clippy * clippy --------- Co-authored-by: Tianyu Zhang <[email protected]> Co-authored-by: Haofei Liang <[email protected]> Co-authored-by: Xiang Xie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConstOne,ConstZero,NegOneandConstNegOne.PowReducetoExpReduce.ExpPowOf2Reducefor improvingGoldilocksandBabyBear.maskanddecompose_lenofDecomposableField.'staticof some traits.Primitiveto defineField::Value, make it supports more operations.