Compare #141
Closed
Compare #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+1
to
+2
| pub mod compare; | ||
| pub mod parameters; |
There was a problem hiding this comment.
Add more comments of this implementation according to the paper.
Suggested change
| pub mod compare; | |
| pub mod parameters; | |
| //! This is the implemenation of the alogirhtm in paper .. in page ... | |
| #![cfg_attr(docsrs, feature(doc_auto_cfg))] | |
| #![deny(missing_docs)] | |
| pub mod compare; | |
| pub mod parameters; |
fhe_cmp/src/compare.rs
Outdated
| use lattice::{LWE, NTTRGSW, RLWE}; | ||
| use rand::prelude::*; | ||
|
|
||
| ///the structrue of Compare's input key |
There was a problem hiding this comment.
Suggested change
| ///the structrue of Compare's input key | |
| /// The structrue of Compare's input key |
fhe_cmp/src/compare.rs
Outdated
Comment on lines
10
to
12
| pub struct Compare<F: Field<Value = u64> + NTTField> { | ||
| key: RLWEBlindRotationKey<F>, | ||
| } |
There was a problem hiding this comment.
Can we just use F: NTTField ?
fhe_cmp/src/compare.rs
Outdated
Comment on lines
14
to
15
| ///the implementation of Compare, including comparison of greater, equality and less | ||
| impl<F: Field<Value = u64> + NTTField> Compare<F> { |
There was a problem hiding this comment.
Suggested change
| ///the implementation of Compare, including comparison of greater, equality and less | |
| impl<F: Field<Value = u64> + NTTField> Compare<F> { | |
| /// The implementation of Compare, including comparison of greater, equality and less | |
| impl<F: Field<Value = u64> + NTTField> Compare<F> { |
fhe_cmp/src/compare.rs
Outdated
Comment on lines
43
to
52
| /// Performs the homomorphic and operation. | ||
| /// | ||
| /// # Arguments | ||
| /// | ||
| /// * Input: blind rotation key `self`. | ||
| /// * Input: LWE ciphertext `ca`, with message `a`. | ||
| /// * Input: LWE ciphertext `cb`, with message `b`. | ||
| /// * Input: the size of test vector `poly_length`. | ||
| /// * Input: encryption of 1 `delta`. | ||
| /// * Output: LWE ciphertext with message `a & b`. |
There was a problem hiding this comment.
We should use the following format for comments.
Suggested change
| /// Performs the homomorphic and operation. | |
| /// | |
| /// # Arguments | |
| /// | |
| /// * Input: blind rotation key `self`. | |
| /// * Input: LWE ciphertext `ca`, with message `a`. | |
| /// * Input: LWE ciphertext `cb`, with message `b`. | |
| /// * Input: the size of test vector `poly_length`. | |
| /// * Input: encryption of 1 `delta`. | |
| /// * Output: LWE ciphertext with message `a & b`. | |
| /// Performs the homomorphic AND operation. | |
| /// | |
| /// # Arguments | |
| /// | |
| /// * `ca` - The LWE ciphertext, with message `a`. | |
| /// * `cb` - The LWE ciphertext, with message `b`. | |
| /// * `poly_length` - The size of test vector. | |
| /// * `delta` - The encryption of 1. | |
| /// * Output - LWE ciphertext with message `a & b`. |
Comment on lines
+260
to
+268
| pub fn encrypt<F, R>( | ||
| mut num1: usize, | ||
| mut num2: usize, | ||
| ntt_ring_secret_key: &NTTPolynomial<F>, | ||
| basis: Basis<F>, | ||
| delta: F, | ||
| error_sampler: FieldDiscreteGaussianSampler, | ||
| mut rng: R, | ||
| ) -> (Vec<RLWE<F>>, Vec<NTTRGSW<F>>) |
There was a problem hiding this comment.
I was thinking of use two encryption algorithms to generate RLWE and RGSW ciphertexts seperately.
This is because the ciphertext is generated from different parties.
| pub fn encrypt<F, R>( | ||
| mut num1: usize, | ||
| mut num2: usize, | ||
| ntt_ring_secret_key: &NTTPolynomial<F>, |
There was a problem hiding this comment.
We should hide this key into the struct.
fhe_cmp/src/compare.rs
Outdated
Comment on lines
306
to
313
| /// decryption for the ciphertext | ||
| pub fn decrypt<F: Field<Value = u64> + NTTField>(sk: &[F], ciphertext: LWE<F>) -> u64 { | ||
| let a_mul_s = sk | ||
| .iter() | ||
| .zip(ciphertext.a()) | ||
| .fold(F::zero(), |acc, (&s, &a)| acc + s * a); | ||
| decode(ciphertext.b() - a_mul_s) | ||
| } |
There was a problem hiding this comment.
The sk should be put into the struct.
fhe_cmp/src/compare.rs
Outdated
Comment on lines
316
to
318
| pub fn decode<F: Field<Value = u64> + NTTField>(c: F) -> u64 { | ||
| (c.value() as f64 * 16_f64 / 132120577_f64).round() as u64 % 16 | ||
| } |
There was a problem hiding this comment.
Do not hardcode the values as constants, it should stored in the parameters, which should be stored in the struct.
Comment on lines
+260
to
+262
| pub fn encrypt<F, R>( | ||
| mut num1: usize, | ||
| mut num2: usize, |
There was a problem hiding this comment.
I think you only consider the case that the inputs are u64, we should also consider the case with inputs in u8, u16, u32, u64 and u128.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.