Add a new key switch method and support q>2N
#135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| let sk = secret_key_pack.lwe_secret_key(); | ||
|
|
||
| let key: Vec<Vec<Vec<LWE<C>>>> = (0..len) |
There was a problem hiding this comment.
Can we parallelize this process?
There was a problem hiding this comment.
Rng makes it unable to parallelize.
Comment on lines
+14
to
+15
| /// - `Modulus Switch`: `q > 2N`, `2N|q` | ||
| /// - `Scale`:`q < 2N`, `q|2N` |
There was a problem hiding this comment.
I think these two cases are essentially the same. Scale is actually a modulus switch process.
There was a problem hiding this comment.
Yes, but their operations are a little different. I need to make them into two types.
Comment on lines
62
to
63
| /// cryptographically secure random number generator | ||
| csrng: RefCell<Prg>, |
There was a problem hiding this comment.
Maybe we should move this csrng out of SecretKeyPack, we could explicitly use rng as an input to a randomized function.
There was a problem hiding this comment.
Yes, some optimization possibilities are limited to a certain extent. However, if you need to change it, another PR is better.
serendipity-crypto
force-pushed
the
qks
branch
from
3d4cbfc to
1cbdcf0
Compare
xiangxiecrypto
approved these changes
Aug 19, 2024
This was referenced Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FheFieldmacrodefault-features