pcs-change #130
pcs-change #130
Conversation
| /// Distance of the linear code when avaible from linear code specification | ||
| fn distance(&self) -> Result<f64, String>; | ||
| /// Proximity gap of the linear code when avaible from linear code specification | ||
| fn proximity_gap(&self) -> Result<f64, String>; |
There was a problem hiding this comment.
Why use Result<f64, String>, any error we need to handle?
There was a problem hiding this comment.
These functions are in CodeSpec trait, so I think some codes' distance and proximity_gap may be not available when only given the code specification.
I can remove it for simplicity.
There was a problem hiding this comment.
We do not need these functions in the trait for now, could remove it.
There was a problem hiding this comment.
We need these function to know distance and proximity gap of the code in BrakedownParams::new(num_vars: usize, code_spec: impl LinearCodeSpec<F, Code = C>) only from code spec instead of code itself.
So we can compute
let estimated_queries = |distance: f64, gap: f64| { ceil(-(BRAKEDOWN_SECURITY_BIT as f64) / (1.0 - distance * gap).log2()) };
before instantiating a code from code_spec.
There was a problem hiding this comment.
ok, then let's change the api to output a f64 type without handling the errors.
| if num_cols > (1 << num_vars) { | ||
| num_cols = 1 << num_vars; | ||
| } |
There was a problem hiding this comment.
| if num_cols > (1 << num_vars) { | |
| num_cols = 1 << num_vars; | |
| } | |
| num_cols = std::cmp::min(num_cols, 1 << num_vars>>); |
No description provided.