Update fund-node.mdx #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrekucci
reviewed
Mar 12, 2024
| @@ -60,7 +68,7 @@ Bidders can withdraw this balance at any point by interacting with the settlemen | |||
| } | |||
| ``` | |||
|
|
|||
| - Add allowance | |||
| - Add to prepaid allowance | |||
There was a problem hiding this comment.
Shouldn't this reflect the wording changes made in (if merged) #5?
There was a problem hiding this comment.
Yea, although we'll need to come to consensus on best wording in primev/mev-commit-p2p#214. Imo that would be prepay_allowance, add_allowance, add_prepaid_allowance etc. But using the word "provide" could be confusing with our existing notion of a provider
shaspitz
force-pushed
the
update-fund-node
branch
from
7d867dc to
c351fc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.