Optimise codebase according to latest pythonic code style #130
Conversation
Codecov Report
@@ Coverage Diff @@
## master #130 +/- ##
==========================================
+ Coverage 83.13% 83.19% +0.05%
==========================================
Files 11 11
Lines 1405 1410 +5
Branches 249 250 +1
==========================================
+ Hits 1168 1173 +5
Misses 159 159
Partials 78 78
Continue to review full report at Codecov.
|
|
I agree with everything you proposed. I would prefer if we can have the f-string change in a separate PR with it's own issue. same with the other changes like including tests, integration with mypy. Will allow smaller changes to be checked in without getting blocked by unrelated blockers. For type annotations, It would be easier to have a single issue tracking other child issues, wherein you can have smaller PR's for maybe each module at a time. Would make reviews easier. |
- Use f-string for string formatting - Remove explicit inheritance from python object - use pythonic APIs like all,any.. wherever possible
|
fixes |
Agent-Hellboy
changed the title
|
@Agent-Hellboy Is this PR still WIP? If yes, can you then add a [WIP] tag before PR's title. If no, let me know and I'll approve this. |
|
This is final |
Consider this as an WIP PR, I will try to cover more methods as I need to solve some circular dependencies, I am thinking of using mypy for type checking, I can see that unittest are missing for base.py, maybe i will add those as well. Or if you want i can create a new issue named
increase code coverageI have made one extra change of converting all instances of
string formatting using .format()to f string.