Add release notes for 0.291 #24445
Add release notes for 0.291 #24445
Conversation
unidevel
requested review from
steveburnett,
elharo and
a team
as code owners
prestodb-ci
requested review from
a team,
infvg and
pratyakshsharma
and removed request for
a team
|
Here are the errors when generating the release notes 2025-01-29T10:44:30.631Z ERROR main com.facebook.presto.release.tasks.GenerateReleaseNotesTask Bad release notes for PR #24341: expect section header, found [Optimizations] |
There was a problem hiding this comment.
For this first pass review of the release notes, I largely limited my scope to addressing the collision of the current practice to manually add PR links to the release note entries and this first use of the automated PR links.
Because of the recent code fix to automatically add the PR number, this edition of the release notes has manual entries and auto-generated entries.
Throughout this review, I have:
- deleted the manual PR link (for example :pr:24103 )
- removed the parentheses around the auto-generated PR link for consistency with previous release note pages
- making sure each release note entry sentence ends with a period before the PR link
I have followed up by asking for the code for auto-gen to drop the parentheses.
|
Thank you @steveburnett , let me update by your comments. |
Co-authored-by: Steve Burnett <[email protected]>
There was a problem hiding this comment.
Thanks for applying all the changes cleaning up the redundant manual PR links! Now that that's out of the way, I was able to do a better job reviewing formatting at the line level, and suggesting that some entries should be moved to different categories.
Also, one thing I haven't done that needs doing:
the PRs listed in the "Missing Release Notes" section of this PR need to be reviewed for whether they should not be included in the release notes, or if a release note entry for those PRs should be written and added in the appropriate section (General Changes, Hive Connector Changes, Security Changes, and so on.)
Co-authored-by: Steve Burnett <[email protected]>
Co-authored-by: Timothy Meehan <[email protected]>
|
@steveburnett I have fixed all the issues in your comments. Please review again. Really appreciate your careful review. |
There was a problem hiding this comment.
Thank you for applying all the comments! Looks good, I think we're almost done.
In this review I did a complete line-level review of the document and caught a few more items.
In addition to those new comments, I'm asking you to reorder the entries in each section, and the sections themselves, following the order shown in the Release Notes Guidelines, as I explained in comments. Ask if anything I've suggested is unclear and we'll figure it out.
Co-authored-by: Steve Burnett <[email protected]>
|
@steveburnett I have updated all the issues and learned a lot from your comments. Thank you! |
There was a problem hiding this comment.
LGTM! (docs)
Pulled updated branch, new local doc build, everything as it is looks good. Great work!
Note: I am marking my review as Comment and not Approve because there is one important part of these release notes that has not yet been addressed:
The PRs in the "Missing Release Notes" section of this PR need to be reviewed for whether they should not be included in the release notes, or if a release note entry for any of those PRs should be written and added in the appropriate section (General Changes, Hive Connector Changes, Security Changes, and so on). Maybe none of them need to be added.
Once those missing release notes have been reviewed, and any entries that are needed are added and reviewed, we're done. But the existing draft of these release notes, barring any possible adds from the missing PRs, is good to merge now.
You're welcome! I try to explain my recommended changes when I can to help people understand why I think a change is for the better. |
|
@steveburnett the missing release notes have been added in the latest commit. PTAL |
|
The only part of the 0.291 release notes not done that I am aware of is the writing of the Highlights. |
|
@tdcmeehan PTAL when you have a chance |
| * Improve coordinator task management performance. `#24369 <https://github.com/prestodb/presto/pull/24369>`_ | ||
| * Improve efficiency of coordinator when running a large number of tasks. `#24288 <https://github.com/prestodb/presto/pull/24288>`_ | ||
| * Improve scheduling for CTE materialization: Now, only the stages containing CTE table scans that reference CTE table write stages are blocked till the write is complete, instead of the entire query being blocked as was the case previously. This is controlled by the session property ``enhanced_cte_scheduling_enabled`` (on by default). `#24108 <https://github.com/prestodb/presto/pull/24108>`_ | ||
| * Improve HTTP responses from async page transport servlet, by sanitizing the URI before use. `#24004 <https://github.com/prestodb/presto/pull/24004>`_ |
There was a problem hiding this comment.
I would try to think of something that is more understandable to the user. No one will understand what an async page transport servlet is.
| * Add :doc:`/sql/alter-table` SET PROPERTIES statement. `#21495 <https://github.com/prestodb/presto/pull/21495>`_ | ||
| * Add :func:`google_polyline_decode` function to convert Google polyline to Presto ST_Geometry types. `#23999 <https://github.com/prestodb/presto/pull/23999>`_ | ||
| * Add :func:`google_polyline_encode` function to convert Presto ST_Geometry to Google polyline types. `#23999 <https://github.com/prestodb/presto/pull/23999>`_ | ||
| * Add Delete, TableWriter, and TableFinish node to SPI. `#24088 <https://github.com/prestodb/presto/pull/24088>`_ |
| * Add :func:`google_polyline_decode` function to convert Google polyline to Presto ST_Geometry types. `#23999 <https://github.com/prestodb/presto/pull/23999>`_ | ||
| * Add :func:`google_polyline_encode` function to convert Presto ST_Geometry to Google polyline types. `#23999 <https://github.com/prestodb/presto/pull/23999>`_ | ||
| * Add Delete, TableWriter, and TableFinish node to SPI. `#24088 <https://github.com/prestodb/presto/pull/24088>`_ | ||
| * Add SemiJoin, Join, TableWriter, Delete, and TableFinish node to connector optimizer. `#24154 <https://github.com/prestodb/presto/pull/24154>`_ |
| * Add :func:`google_polyline_encode` function to convert Presto ST_Geometry to Google polyline types. `#23999 <https://github.com/prestodb/presto/pull/23999>`_ | ||
| * Add Delete, TableWriter, and TableFinish node to SPI. `#24088 <https://github.com/prestodb/presto/pull/24088>`_ | ||
| * Add SemiJoin, Join, TableWriter, Delete, and TableFinish node to connector optimizer. `#24154 <https://github.com/prestodb/presto/pull/24154>`_ | ||
| * Add ``ClientRequestFilter.java`` interface in Presto-spi. `#23380 <https://github.com/prestodb/presto/pull/23380>`_ |
There was a problem hiding this comment.
| * Add ``ClientRequestFilter.java`` interface in Presto-spi. `#23380 <https://github.com/prestodb/presto/pull/23380>`_ | |
| * Add ``ClientRequestFilter` . `#23380 <https://github.com/prestodb/presto/pull/23380>`_ |
Link to docs which were added for this interface.
There was a problem hiding this comment.
That doc link should be
:doc:`/develop/client-request-filter`
| * Add ``ClientRequestFilter.java`` interface in Presto-spi. `#23380 <https://github.com/prestodb/presto/pull/23380>`_ | ||
| * Add a configuration property ``plan-checker.config-dir`` to set the configuration directory for PlanCheckerProvider configurations. `#23955 <https://github.com/prestodb/presto/pull/23955>`_ | ||
| * Add a session property ``include_values_node_in_connector_optimizer`` to enable connector optimizer optimize plans with values node. `#24227 <https://github.com/prestodb/presto/pull/24227>`_ | ||
| * Add an optional input distribution constraint to DeleteNode. `#24104 <https://github.com/prestodb/presto/pull/24104>`_ |
There was a problem hiding this comment.
I think we can remove this, it's not user facing AFAIA
| * Add single worker execution. To improve latency of tiny queries running on a large cluster, we introduce single worker execution mode: query will only use one node to execute and plan would be optimized accordingly. This feature can be turned on by the configuration property ``single-node-execution-enabled`` or the session property ``single_node_execution_enabled``. `#24172 <https://github.com/prestodb/presto/pull/24172>`_ | ||
| * Add support for ORC metadata cache invalidation based on file modification time. `#24346 <https://github.com/prestodb/presto/pull/24346>`_ | ||
| * Add support for ``ALTER VIEW RENAME TO`` operation, including the necessary infrastructure for connector implementations. `#23749 <https://github.com/prestodb/presto/pull/23749>`_ | ||
| * Add support for ``BigInt`` data type in the SQL Client on Presto UI on supported browsers. See `compatibility <https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/parse#browser_compatibility>`_ for the supported browsers. `#24336 <https://github.com/prestodb/presto/pull/24336>`_ |
There was a problem hiding this comment.
I would move this to a new section for the UI.
| * Add support for ``ALTER VIEW RENAME TO`` operation, including the necessary infrastructure for connector implementations. `#23749 <https://github.com/prestodb/presto/pull/23749>`_ | ||
| * Add support for ``BigInt`` data type in the SQL Client on Presto UI on supported browsers. See `compatibility <https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/parse#browser_compatibility>`_ for the supported browsers. `#24336 <https://github.com/prestodb/presto/pull/24336>`_ | ||
| * Add support for the histogram statistic type. `#22365 <https://github.com/prestodb/presto/pull/22365>`_ | ||
| * Add support for time type partitioning in the ORC file format for Iceberg. `#24091 <https://github.com/prestodb/presto/pull/24091>`_ |
|
|
||
| BigQuery Connector Changes | ||
| __________________________ | ||
| * Fix for BigQuery ``SELECT``. `#23957 <https://github.com/prestodb/presto/pull/23957>`_ |
There was a problem hiding this comment.
This needs something a little more descriptive
|
|
||
| Iceberg Connector Changes | ||
| _________________________ | ||
| * Improve redundant getTable calls in Iceberg Connector. `#24376 <https://github.com/prestodb/presto/pull/24376>`_ |
There was a problem hiding this comment.
What about Improve performance of scan planning in Iceberg connector?
Missing Release Notes
Abhisek Saikia
Christian Zentgraf
Deepak Mehra
Heidi Han
Jalpreet Singh Nanda (:imjalpreet)
Jiaqi Zhang
Joe Abraham
Luís Fernandes
MariamAlmesfer
Natasha Sehgal
Nishitha-Bhaskaran
Pramod Satya
Richard Barnes
Shakyan Kushwaha
Shang Ma
Tim Meehan
Xiao Du
Xiaoxuan Meng
Yihong Wang
Zac Blanco
dependabot[bot]
zuyu
Extracted Release Notes
/sql/alter-tableSET PROPERTIES statement :pr:21495.22365.ClientRequestFilter.javainterface in Presto-spi. :pr:23380.23380.catalog.system.invalidate_metastore_cacheprocedure to invalidate all, or portions of, the metastore cache. :pr:23401.catalog.system.invalidate_metastore_cacheprocedure to invalidate all, or portions of, the metastore cache. :pr:23401.catalog.system.invalidate_metastore_cacheprocedure to invalidate all, or portions of, the metastore cache. :pr:23401.catalog.system.invalidate_metastore_cacheprocedure to invalidate all, or portions of, the metastore cache. :pr:23401.23596.ALTER VIEW RENAME TOoperation, including the necessary infrastructure for connector implementations. :pr:23749.ALTER VIEW RENAME TO. :pr:23749.ALTER VIEW RENAME TO. :pr:23749.viewfor Iceberg connector when configured withRESTandNESSIE. :pr:23793.23882.23903.23929.CVE-2024-47561 <https://github.com/advisories/GHSA-r7pg-v2c8-mfg3>_. :pr:23868.plan-checker.config-dirto set the configuration directory for PlanCheckerProvider configurations. :pr:23955.PlanCheckerProviderFactory.createto pass in a map of configuration properties and replaceSimplePlanFragmentSerdewith aPlanCheckerProviderContext. :pr:23955.SELECT. :pr:23957.23976.23976.google_polyline_decodefunction to convert Google polyline to Presto ST_Geometry types. :pr:23999.google_polyline_encodefunction to convert Presto ST_Geometry to Google polyline types. :pr:23999.24004.native_spill_prefixsort_enabled,native_prefixsort_normalized_key_max_bytes, andnative_prefixsort_min_rows. :pr:24043.CVE-2024-45296 <https://www.cve.org/CVERecord?id=CVE-2024-45296>_. :pr:24048.CVE-2022-25647 <https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-25647>:pr:24051.CVE-2022-25647 <https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-25647>:pr:24051.query-data-cache-enabled-defaultconfiguration property to align C++ cache behavior with Java. Set it totrue(default) for current C++ behavior or tofalseto match Java's cache logic. :pr:24076.iceberg.rest.nested.namespace.enabledto support nested namespaces in Iceberg's REST Catalog. Defaults totrue. :pr:24083.24088.24091.24091.24095.width_bucket(x, bins) -> bigintwhich previously treated allnullelements in bins as0. Now the function will throw an error if it finds anullor non-finite element inbins.. :pr:24103.24104.getNewTableLayout,getInsertLayoutmethods :pr:12345.scale-writersby default. :pr:24107.enhanced_cte_scheduling_enabled(on by default) :pr:24108.#24111.CVE-2016-1000027 <https://www.mend.io/vulnerability-database/CVE-2016-1000027>_. :pr:24112.CVE-2018-1272 <https://www.mend.io/vulnerability-database/CVE-2018-1272>_. :pr:24112.CVE-2022-22970 <https://www.mend.io/vulnerability-database/CVE-2022-22970>_. :pr:24112.CVE-2024-22243 <https://www.mend.io/vulnerability-database/CVE-2024-22243>_. :pr:24112.CVE-2024-22259 <https://www.mend.io/vulnerability-database/CVE-2024-22259>_. :pr:24112.CVE-2021-22096 <https://www.mend.io/vulnerability-database/CVE-2021-22096>_. :pr:24112.CVE-2024-8184 <https://www.mend.io/vulnerability-database/CVE-2024-8184>_. :pr:24112.CVE-2024-6763 <https://www.mend.io/vulnerability-database/CVE-2024-6763>_. :pr:24112.CVE-2021-22060 <https://www.mend.io/vulnerability-database/CVE-2021-22060>_. :pr:24112.CVE-2024-22262 <https://www.mend.io/vulnerability-database/CVE-2024-22262>_. :pr:24112.CVE-2021-22096 <https://www.mend.io/vulnerability-database/CVE-2021-22096>_. :pr:24112.CVE-2023-20883 <https://www.mend.io/vulnerability-database/CVE-2023-20883>_. :pr:24112.CVE-2021-0170 <https://www.mend.io/vulnerability-database/CVE-2021-0170>_. :pr:24112.CVE-2018-1199 <https://www.mend.io/vulnerability-database/CVE-2018-1199>_. :pr:24112.CVE-2024-6763 <https://www.mend.io/vulnerability-database/CVE-2024-6763>_. :pr:24112.CVE-2015-5211 <https://www.mend.io/vulnerability-database/CVE-2015-5211>_. :pr:24112.CVE-2015-3192 <https://www.mend.io/vulnerability-database/CVE-2015-3192>_. :pr:24112.CVE-2022-27772 <https://www.mend.io/vulnerability-database/CVE-2022-27772>_. :pr:24112.CVE-2020-5421 <https://www.mend.io/vulnerability-database/CVE-2020-5421>_. :pr:24112.CVE-2024-38809 <https://www.mend.io/vulnerability-database/CVE-2024-38809>_. :pr:24112.CVE-2022-22965 <https://www.mend.io/vulnerability-database/CVE-2022-22965>_. :pr:24112.CVE-2022-22970 <https://www.mend.io/vulnerability-database/CVE-2022-22970>_. :pr:24112.CWE-759 <https://cwe.mitre.org/data/definitions/759.htm>_. :pr:24132.CVE-2024-47535 <https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-47535>_. :pr:24137.experimental.table-writer-merge-operator-enabled` config property and thetable_writer_merge_operator_enabled`` session property :pr:12345.24153.24154.native_execution_scale_partitioned_writer_threads_enabledsession property. Native execution only. :pr:24155.24163.single-node-execution-enabledor session propertysingle_node_execution_enabled.:pr:24172./sql/usestatement. :pr:24182.CVE-2024-8184 <https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-8184>_. :pr:24184.24199.24206.RESTandNESSIE. :pr:24218.include_values_node_in_connector_optimizerto enable connector optimizer optimize plans with values node :pr:12345.alluxio-shaded-clientwithalluxio-corelibraries libraries in response toCVE-2023-44981 <https://github.com/advisories/GHSA-7286-pgfv-vxvh>_. :pr:24231.24247.CVE-2020-0287 <https://nvd.nist.gov/vuln/detail/CVE-2020-0287>_. :pr:24249.24270.Content-Security-Policy,X-Content-Type-Options. See reference docsContent-Security-Policy <https://developer.mozilla.org/en-US/docs/Web/HTTP/CSP>_ andX-Content-Type-Options <https://learn.microsoft.com/en-us/previous-versions/windows/internet-explorer/ie-developer/compatibility/gg622941(v=vs.85)>_. :pr:24272.RowExpression. :pr:24287.24288.24326.QueryResultcomponent #24336 (Author: Yihong Wang): Support BigInt in theQueryResultcomponentBigIntdata type in the SQL Client on Presto UI on supported browsers. Seecompatibility <https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/parse#browser_compatibility>_ for the supported browsers. :pr:24336.24346./connector/mongodb. :pr:24352.24369.query-data-cache-enabled-defaultconfiguration property, which is no longer needed as per-split fine-grained cache control has been introduced. :pr:24372.24376.java:S4423 <https://sonarqube.ow2.org/coding_rules?open=java%3AS4423&rule_key=java%3AS4423>_. :pr:24436.All Commits
##in Iceberg document (wangd)QueryResultcomponent (Support BigInt in theQueryResultcomponent #24336) (Yihong Wang)Optional.orElseGetthanorElseto avoid unnecessary calculation (wangd)USEstatement when schema does not exist (hantangwangd)TableNotFoundException(hantangwangd)alter tabledocument (hantangwangd)TABLE_COMMENTdeclared in IcebergNativeMetadata (wangd)