Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native] Return only header for datasize request #24437

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zation99
Copy link
Contributor

Description

When responding data size request, a body can be returned with up to 1M of data. If there are a lot of sources, it can lead to large amount of mem use.
This patch makes it only return the header when requesting data size.
Note that this still calls getData() same as previously. An alternative approach is tested where we immediately return the target buffer bytes size without invoking getData(). While it works, it leads to more requests made from the consumers because its driver just keeps requesting it. So we still keep this approach.

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==


If release note is NOT required, use:

== NO RELEASE NOTE ==


@zation99 zation99 requested a review from a team as a code owner January 27, 2025 07:02
@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Jan 27, 2025
@zation99 zation99 requested a review from xiaoxmeng January 27, 2025 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:Meta PR from Meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants