Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Iceberg] Add table and session property for split size #24417

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ZacBlanco
Copy link
Contributor

@ZacBlanco ZacBlanco commented Jan 23, 2025

Description

Adds a session property for target split size.

Closes #24419

Motivation and Context

Makes it easier to do performance debugging by setting the desired split size on a per-query basis.

Impact

New configuration property.

Test Plan

unit tests

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== RELEASE NOTES ==

Iceberg Connector Changes
* Add target_split_size session property :pr:`24417`

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Jan 23, 2025
@steveburnett
Copy link
Contributor

Thanks for the release note! Nit formatting suggestion.

== RELEASE NOTES ==

Iceberg Connector Changes
* Add ``target_split_size session`` property. :pr:`24417`

Consider documenting the new session property, perhaps in
https://github.com/prestodb/presto/blob/master/presto-docs/src/main/sphinx/connector/iceberg.rst#session-properties .

@ZacBlanco ZacBlanco force-pushed the upstream-iceberg-split-size branch from d42702a to 958ceec Compare January 25, 2025 00:21
steveburnett
steveburnett previously approved these changes Jan 27, 2025
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull branch, local doc build, looks good. Thanks!

@ZacBlanco ZacBlanco force-pushed the upstream-iceberg-split-size branch from 9537be5 to abe3332 Compare January 27, 2025 20:59
@ZacBlanco ZacBlanco force-pushed the upstream-iceberg-split-size branch from abe3332 to 4a07851 Compare January 27, 2025 22:14
@ZacBlanco ZacBlanco marked this pull request as ready for review January 28, 2025 01:36
@ZacBlanco ZacBlanco requested review from elharo, hantangwangd and a team as code owners January 28, 2025 01:36
@ZacBlanco ZacBlanco requested a review from presto-oss January 28, 2025 01:36
@ZacBlanco ZacBlanco changed the title [Iceberg] Session property for target split size [Iceberg] Add table and session property for split size Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:IBM PR from IBM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make iceberg table target split size configurable
3 participants