-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new configuration to pass catalog name to metastore when creati… #24235
Draft
AnuragKDwivedi
wants to merge
18
commits into
prestodb:master
Choose a base branch
from
AnuragKDwivedi:catalog-name-to-metastore
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Added new configuration to pass catalog name to metastore when creati… #24235
AnuragKDwivedi
wants to merge
18
commits into
prestodb:master
from
AnuragKDwivedi:catalog-name-to-metastore
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6f7ea4df0d7a6814077a05242950c5dce3bb1831.
AnuragKDwivedi
force-pushed
the
catalog-name-to-metastore
branch
from
December 12, 2024 05:28
00027a7
to
e72d7ff
Compare
prestodb-ci
requested review from
a team,
ShahimSharafudeen and
Dilli-Babu-Godari
and removed request for
a team
December 13, 2024 15:18
Saved that user @AnuragKDwivedi is from IBM |
6 tasks
Consider adding documentation for this configuration property. Perhaps in https://github.com/prestodb/presto/blob/master/presto-docs/src/main/sphinx/admin/properties.rst. |
…given catalog Revised getDatabases implementation to pull all database names for a given catalog. If the catalog name is not present then getAllDatabases method will be called.
… and primary key api calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to pass catalog name in the create schema request to metastore.
Description
This PR includes the changes in presto code to pass catalog name in the create schema request to metastore service.
Motivation and Context
#22895
Impact
NA
Test Plan
CI passed
Contributor checklist