Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new configuration to pass catalog name to metastore when creati… #24235

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

AnuragKDwivedi
Copy link

@AnuragKDwivedi AnuragKDwivedi commented Dec 10, 2024

Changes to pass catalog name in the create schema request to metastore.

Description

This PR includes the changes in presto code to pass catalog name in the create schema request to metastore service.

Motivation and Context

#22895

Impact

NA

Test Plan

CI passed

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
== RELEASE NOTES ==
General Changes
* item 1 ... :pr:`24235`

@AnuragKDwivedi AnuragKDwivedi force-pushed the catalog-name-to-metastore branch from 00027a7 to e72d7ff Compare December 12, 2024 05:28
@tdcmeehan tdcmeehan added the from:IBM PR from IBM label Dec 13, 2024
@prestodb-ci prestodb-ci requested review from a team, ShahimSharafudeen and Dilli-Babu-Godari and removed request for a team December 13, 2024 15:18
@prestodb-ci
Copy link

Saved that user @AnuragKDwivedi is from IBM

@steveburnett
Copy link
Contributor

Consider adding documentation for this configuration property. Perhaps in https://github.com/prestodb/presto/blob/master/presto-docs/src/main/sphinx/admin/properties.rst.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:IBM PR from IBM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants