Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not review] [WIP] TPC-DS test branch #23693

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

pdabre12
Copy link
Contributor

Adds a config property tpcds.toggle-char-to-varchar to toggle all char columns to varchar in the TPC-DS connector. This change is required because Presto - native execution does not support char data type.

@pdabre12 pdabre12 force-pushed the config-property-tpcds-connector branch 4 times, most recently from af23a91 to c365529 Compare December 12, 2024 00:54
@pdabre12 pdabre12 force-pushed the config-property-tpcds-connector branch 2 times, most recently from cb7ebbd to dc2218a Compare December 17, 2024 01:56
@pdabre12 pdabre12 force-pushed the config-property-tpcds-connector branch from dc2218a to fadc1bb Compare January 13, 2025 08:15
steveburnett
steveburnett previously approved these changes Jan 13, 2025
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull branch, local doc build, looks good. Thanks!

@pdabre12 pdabre12 force-pushed the config-property-tpcds-connector branch from 01b9339 to cf0c373 Compare January 21, 2025 22:04
@pdabre12 pdabre12 changed the title [WIP] Add config property 'tpcds.toggle-char-to-varchar' [Do not review] [WIP] TPC-DS test branch Jan 21, 2025
@pdabre12 pdabre12 force-pushed the config-property-tpcds-connector branch 3 times, most recently from 0208934 to a9c2e20 Compare January 24, 2025 23:35
@pdabre12 pdabre12 force-pushed the config-property-tpcds-connector branch from a9c2e20 to 6035ab7 Compare January 24, 2025 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants