-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Do not review] [WIP] TPC-DS test branch #23693
Draft
pdabre12
wants to merge
7
commits into
prestodb:master
Choose a base branch
from
pdabre12:config-property-tpcds-connector
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[Do not review] [WIP] TPC-DS test branch #23693
pdabre12
wants to merge
7
commits into
prestodb:master
from
pdabre12:config-property-tpcds-connector
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdabre12
force-pushed
the
config-property-tpcds-connector
branch
4 times, most recently
from
December 12, 2024 00:54
af23a91
to
c365529
Compare
pdabre12
force-pushed
the
config-property-tpcds-connector
branch
2 times, most recently
from
December 17, 2024 01:56
cb7ebbd
to
dc2218a
Compare
pdabre12
force-pushed
the
config-property-tpcds-connector
branch
from
January 13, 2025 08:15
dc2218a
to
fadc1bb
Compare
steveburnett
previously approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (docs)
Pull branch, local doc build, looks good. Thanks!
pdabre12
force-pushed
the
config-property-tpcds-connector
branch
from
January 21, 2025 22:04
01b9339
to
cf0c373
Compare
pdabre12
changed the title
[WIP] Add config property 'tpcds.toggle-char-to-varchar'
[Do not review] [WIP] TPC-DS test branch
Jan 21, 2025
pdabre12
force-pushed
the
config-property-tpcds-connector
branch
3 times, most recently
from
January 24, 2025 23:35
0208934
to
a9c2e20
Compare
Co-authored-by: Pramod Satya <[email protected]>
pdabre12
force-pushed
the
config-property-tpcds-connector
branch
from
January 24, 2025 23:52
a9c2e20
to
6035ab7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a config property
tpcds.toggle-char-to-varchar
to toggle all char columns to varchar in the TPC-DS connector. This change is required because Presto - native execution does not support char data type.