-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add a config property for excluding invalid worker session properties
- Loading branch information
Showing
8 changed files
with
163 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 56 additions & 0 deletions
56
...a/com/facebook/presto/tests/TestSetWorkerSessionPropertiesExcludingInvalidProperties.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.facebook.presto.tests; | ||
|
|
||
| import com.facebook.presto.testing.MaterializedResult; | ||
| import com.facebook.presto.testing.QueryRunner; | ||
| import org.intellij.lang.annotations.Language; | ||
| import org.testng.annotations.Test; | ||
|
|
||
| import static com.facebook.presto.testing.TestingSession.testSessionBuilder; | ||
| import static org.testng.Assert.assertEquals; | ||
|
|
||
| public class TestSetWorkerSessionPropertiesExcludingInvalidProperties | ||
| extends AbstractTestQueryFramework | ||
| { | ||
| @Override | ||
| protected QueryRunner createQueryRunner() | ||
| throws Exception | ||
| { | ||
| return DistributedQueryRunner.builder(testSessionBuilder().build()) | ||
| .setSingleCoordinatorProperty("exclude-invalid-worker-session-properties", "true") | ||
| .build(); | ||
| } | ||
|
|
||
| @Test | ||
| public void testSetSessionInvalidNativeWorkerSessionProperty() | ||
| { | ||
| // SET SESSION on a native-worker session property | ||
| assertQueryFails("SET SESSION native_expression_max_array_size_in_reduce=50000", "line 1:1: Session property native_expression_max_array_size_in_reduce does not exist"); | ||
| } | ||
|
|
||
| @Test | ||
| public void testSetSessionValidJavaWorkerSessionProperty() | ||
| { | ||
| // SET SESSION on a java-worker session property | ||
| @Language("SQL") String setSession = "SET SESSION distinct_aggregation_spill_enabled=false"; | ||
| MaterializedResult setSessionResult = computeActual(setSession); | ||
| assertEquals( | ||
| setSessionResult.toString(), | ||
| "MaterializedResult{rows=[[true]], " + | ||
| "types=[boolean], " + | ||
| "setSessionProperties={distinct_aggregation_spill_enabled=false}, " + | ||
| "resetSessionProperties=[], updateType=SET SESSION}"); | ||
| } | ||
| } |
61 changes: 61 additions & 0 deletions
61
...a/com/facebook/presto/tests/TestSetWorkerSessionPropertiesIncludingInvalidProperties.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.facebook.presto.tests; | ||
|
|
||
| import com.facebook.presto.testing.MaterializedResult; | ||
| import com.facebook.presto.testing.QueryRunner; | ||
| import org.intellij.lang.annotations.Language; | ||
| import org.testng.annotations.Test; | ||
|
|
||
| import static com.facebook.presto.testing.TestingSession.testSessionBuilder; | ||
| import static org.testng.Assert.assertEquals; | ||
|
|
||
| public class TestSetWorkerSessionPropertiesIncludingInvalidProperties | ||
| extends AbstractTestQueryFramework | ||
| { | ||
| @Override | ||
| protected QueryRunner createQueryRunner() | ||
| throws Exception | ||
| { | ||
| return DistributedQueryRunner.builder(testSessionBuilder().build()).build(); | ||
| } | ||
|
|
||
| @Test | ||
| public void testSetSessionValidNativeWorkerSessionProperty() | ||
| { | ||
| // SET SESSION on a native-worker session property | ||
| @Language("SQL") String setSession = "SET SESSION native_expression_max_array_size_in_reduce=50000"; | ||
| MaterializedResult setSessionResult = computeActual(setSession); | ||
| assertEquals( | ||
| setSessionResult.toString(), | ||
| "MaterializedResult{rows=[[true]], " + | ||
| "types=[boolean], " + | ||
| "setSessionProperties={native_expression_max_array_size_in_reduce=50000}, " + | ||
| "resetSessionProperties=[], updateType=SET SESSION}"); | ||
| } | ||
|
|
||
| @Test | ||
| public void testSetSessionValidJavaWorkerSessionProperty() | ||
| { | ||
| // SET SESSION on a java-worker session property | ||
| @Language("SQL") String setSession = "SET SESSION distinct_aggregation_spill_enabled=false"; | ||
| MaterializedResult setSessionResult = computeActual(setSession); | ||
| assertEquals( | ||
| setSessionResult.toString(), | ||
| "MaterializedResult{rows=[[true]], " + | ||
| "types=[boolean], " + | ||
| "setSessionProperties={distinct_aggregation_spill_enabled=false}, " + | ||
| "resetSessionProperties=[], updateType=SET SESSION}"); | ||
| } | ||
| } |