Add JDK 17 build support

along with existing support for JDK 8 Co-authored-by: Zac Blanco <[email protected]> Co-authored-by: Jalpreet Singh Nanda (:imjalpreet) <[email protected]>
prestodb · Mar 5, 2025 · 43475ad · 43475ad
1 parent d99256b
commit 43475ad
Show file tree

Hide file tree

Showing 33 changed files with 396 additions and 72 deletions.
diff --git a/.github/workflows/cleanup.yml b/.github/workflows/cleanup.yml
diff --git a/.github/workflows/hive-tests.yml b/.github/workflows/hive-tests.yml
@@ -31,12 +31,16 @@ jobs:
             - '!presto-docs/**'
 
   hive-tests:
+    strategy:
+      fail-fast: false
+      matrix:
+        java: [ 8, 17.0.13 ]
     runs-on: ubuntu-latest
     needs: changes
     if: needs.changes.outputs.codechange == 'true'
     timeout-minutes: 60
     concurrency:
-      group: ${{ github.workflow }}-hive-tests-${{ github.event.pull_request.number }}
+      group: ${{ github.workflow }}-hive-tests-${{ github.event.pull_request.number }}-${{ matrix.java }}
       cancel-in-progress: true
     steps:
       - uses: actions/checkout@v4
@@ -45,7 +49,7 @@ jobs:
       - uses: actions/setup-java@v4
         with:
           distribution: 'temurin'
-          java-version: 8
+          java-version: ${{ matrix.java }}
           cache: 'maven'
       - name: Download nodejs to maven cache
         run: .github/bin/download_nodejs
@@ -75,12 +79,16 @@ jobs:
           fi
 
   hive-dockerized-tests:
+    strategy:
+      fail-fast: false
+      matrix:
+        java: [ 8, 17.0.13 ]
     runs-on: ubuntu-latest
     needs: changes
     if: needs.changes.outputs.codechange == 'true'
     timeout-minutes: 20
     concurrency:
-      group: ${{ github.workflow }}-hive-dockerized-tests-${{ github.event.pull_request.number }}
+      group: ${{ github.workflow }}-hive-dockerized-tests-${{ github.event.pull_request.number }}-${{ matrix.java }}
       cancel-in-progress: true
     steps:
       - uses: actions/checkout@v4
@@ -89,7 +97,7 @@ jobs:
       - uses: actions/setup-java@v4
         with:
           distribution: 'temurin'
-          java-version: 8
+          java-version: ${{ matrix.java }}
           cache: 'maven'
       - name: Download nodejs to maven cache
         run: .github/bin/download_nodejs

diff --git a/.github/workflows/kudu.yml b/.github/workflows/kudu.yml
@@ -29,12 +29,16 @@ jobs:
           codechange:
             - '!presto-docs/**'
   kudu:
+    strategy:
+      fail-fast: false
+      matrix:
+        java: [ 8, 17.0.13 ]
     runs-on: ubuntu-latest
     needs: changes
     if: needs.changes.outputs.codechange == 'true'
     timeout-minutes: 60
     concurrency:
-      group: ${{ github.workflow }}-kudu-${{ github.event.pull_request.number }}
+      group: ${{ github.workflow }}-kudu-${{ github.event.pull_request.number }}-${{ matrix.java }}
       cancel-in-progress: true
     steps:
       - uses: actions/checkout@v4
@@ -43,7 +47,7 @@ jobs:
       - uses: actions/setup-java@v4
         with:
           distribution: 'temurin'
-          java-version: 8
+          java-version: ${{ matrix.java }}
           cache: 'maven'
       - name: Download nodejs to maven cache
         run: .github/bin/download_nodejs

diff --git a/.github/workflows/maven-checks.yml b/.github/workflows/maven-checks.yml
@@ -12,10 +12,14 @@ env:
 
 jobs:
   maven-checks:
+    strategy:
+      fail-fast: false
+      matrix:
+        java: [ 8, 17.0.13 ]
     runs-on: ubuntu-latest
     timeout-minutes: 45
     concurrency:
-      group: ${{ github.workflow }}-maven-checks-${{ github.event.pull_request.number }}
+      group: ${{ github.workflow }}-maven-checks-${{ github.event.pull_request.number }}-${{ matrix.java }}
       cancel-in-progress: true
     steps:
       - name: Free Disk Space
@@ -29,7 +33,7 @@ jobs:
       - uses: actions/setup-java@v4
         with:
           distribution: 'temurin'
-          java-version: 8
+          java-version: ${{ matrix.java }}
           cache: 'maven'
       - name: Download nodejs to maven cache
         run: .github/bin/download_nodejs

diff --git a/.github/workflows/product-tests-basic-environment.yml b/.github/workflows/product-tests-basic-environment.yml
@@ -29,12 +29,16 @@ jobs:
           codechange:
             - '!presto-docs/**'
   product-tests-basic-environment:
+    strategy:
+      fail-fast: false
+      matrix:
+        java: [ 8, 17.0.13 ]
     runs-on: ubuntu-latest
     needs: changes
     if: needs.changes.outputs.codechange == 'true'
     timeout-minutes: 60
     concurrency:
-      group: ${{ github.workflow }}-product-tests-basic-environment-${{ github.event.pull_request.number }}
+      group: ${{ github.workflow }}-product-tests-basic-environment-${{ github.event.pull_request.number }}-${{ matrix.java }}
       cancel-in-progress: true
     steps:
       - name: Free Disk Space
@@ -49,7 +53,7 @@ jobs:
       - uses: actions/setup-java@v4
         with:
           distribution: 'temurin'
-          java-version: 8
+          java-version: ${{ matrix.java }}
           cache: 'maven'
       - name: Download nodejs to maven cache
         run: .github/bin/download_nodejs
@@ -58,4 +62,6 @@ jobs:
           export MAVEN_OPTS="${MAVEN_INSTALL_OPTS}"
           ./mvnw install ${MAVEN_FAST_INSTALL} -am -pl '!presto-docs,!presto-spark-package,!presto-spark-launcher,!presto-spark-testing,!presto-test-coverage'
       - name: Run Product Tests Basic Environment
+        env:
+          OVERRIDE_JDK_DIR: ${{ env.JAVA_HOME }}
         run: presto-product-tests/bin/run_on_docker.sh multinode -x quarantine,big_query,storage_formats,profile_specific_tests,tpcds,cassandra,mysql_connector,postgresql_connector,mysql,kafka,avro
diff --git a/.github/workflows/product-tests-specific-environment.yml b/.github/workflows/product-tests-specific-environment.yml
@@ -29,12 +29,16 @@ jobs:
           codechange:
             - '!presto-docs/**'
   product-tests-specific-environment1:
+    strategy:
+      fail-fast: false
+      matrix:
+        java: [ 8, 17.0.13 ]
     runs-on: ubuntu-latest
     needs: changes
     if: needs.changes.outputs.codechange == 'true'
     timeout-minutes: 60
     concurrency:
-      group: ${{ github.workflow }}-product-tests-specific-environment1-${{ github.event.pull_request.number }}
+      group: ${{ github.workflow }}-product-tests-specific-environment1-${{ github.event.pull_request.number }}-${{ matrix.java }}
       cancel-in-progress: true
     steps:
       - name: Free Disk Space
@@ -49,7 +53,7 @@ jobs:
       - uses: actions/setup-java@v4
         with:
           distribution: 'temurin'
-          java-version: 8
+          java-version: ${{ matrix.java }}
           cache: 'maven'
       - name: Download nodejs to maven cache
         run: .github/bin/download_nodejs
@@ -58,26 +62,40 @@ jobs:
           export MAVEN_OPTS="${MAVEN_INSTALL_OPTS}"
           ./mvnw install ${MAVEN_FAST_INSTALL} -am -pl '!presto-docs,!presto-spark-package,!presto-spark-launcher,!presto-spark-testing,!presto-test-coverage'
       - name: Product Tests Specific 1.1
+        env:
+          OVERRIDE_JDK_DIR: ${{ env.JAVA_HOME }}
         run: presto-product-tests/bin/run_on_docker.sh singlenode -g hdfs_no_impersonation,avro
       - name: Product Tests Specific 1.2
+        env:
+          OVERRIDE_JDK_DIR: ${{ env.JAVA_HOME }}
         run: presto-product-tests/bin/run_on_docker.sh singlenode-kerberos-hdfs-no-impersonation -g hdfs_no_impersonation
       # temporarily disable this flaky run. see issue #20388 for details
       # - name: Product Tests Specific 1.3
       #  run: presto-product-tests/bin/run_on_docker.sh singlenode-hdfs-impersonation -g storage_formats,cli,hdfs_impersonation
       - name: Product Tests Specific 1.4
+        env:
+          OVERRIDE_JDK_DIR: ${{ env.JAVA_HOME }}
         run: presto-product-tests/bin/run_on_docker.sh singlenode-kerberos-hdfs-impersonation -g storage_formats,cli,hdfs_impersonation,authorization,hive_file_header
       - name: Product Tests Specific 1.5
+        env:
+          OVERRIDE_JDK_DIR: ${{ env.JAVA_HOME }}
         run: presto-product-tests/bin/run_on_docker.sh singlenode-kerberos-hdfs-impersonation-cross-realm -g storage_formats,cli,hdfs_impersonation
       - name: Product Tests Specific 1.6
+        env:
+          OVERRIDE_JDK_DIR: ${{ env.JAVA_HOME }}
         run: presto-product-tests/bin/run_on_docker.sh multinode-tls-kerberos -g cli,group-by,join,tls
 
   product-tests-specific-environment2:
+    strategy:
+      fail-fast: false
+      matrix:
+        java: [ 8, 17.0.13 ]
     runs-on: ubuntu-latest
     needs: changes
     if: needs.changes.outputs.codechange == 'true'
     timeout-minutes: 60
     concurrency:
-      group: ${{ github.workflow }}-product-tests-specific-environment2-${{ github.event.pull_request.number }}
+      group: ${{ github.workflow }}-product-tests-specific-environment2-${{ github.event.pull_request.number }}-${{ matrix.java }}
       cancel-in-progress: true
     steps:
       - name: Free Disk Space
@@ -92,7 +110,7 @@ jobs:
       - uses: actions/setup-java@v4
         with:
           distribution: 'temurin'
-          java-version: 8
+          java-version: ${{ matrix.java }}
           cache: 'maven'
       - name: Download nodejs to maven cache
         run: .github/bin/download_nodejs
@@ -101,19 +119,33 @@ jobs:
           export MAVEN_OPTS="${MAVEN_INSTALL_OPTS}"
           ./mvnw install ${MAVEN_FAST_INSTALL} -am -pl '!presto-docs,!presto-spark-package,!presto-spark-launcher,!presto-spark-testing,!presto-test-coverage'
       - name: Product Tests Specific 2.1
+        env:
+          OVERRIDE_JDK_DIR: ${{ env.JAVA_HOME }}
         run: presto-product-tests/bin/run_on_docker.sh singlenode-ldap -g ldap -x simba_jdbc
       - name: Product Tests Specific 2.2
+        env:
+          OVERRIDE_JDK_DIR: ${{ env.JAVA_HOME }}
         run: presto-product-tests/bin/run_on_docker.sh multinode-tls -g smoke,cli,group-by,join,tls
       - name: Product Tests Specific 2.3
+        env:
+          OVERRIDE_JDK_DIR: ${{ env.JAVA_HOME }}
         run: presto-product-tests/bin/run_on_docker.sh singlenode-mysql -g mysql_connector,mysql
       - name: Product Tests Specific 2.4
+        env:
+          OVERRIDE_JDK_DIR: ${{ env.JAVA_HOME }}
         run: presto-product-tests/bin/run_on_docker.sh singlenode-postgresql -g postgresql_connector
       - name: Product Tests Specific 2.5
+        env:
+          OVERRIDE_JDK_DIR: ${{ env.JAVA_HOME }}
         run: presto-product-tests/bin/run_on_docker.sh singlenode-cassandra -g cassandra
       # temporarily disable this flaky run. see issue #20388 for details
       # - name: Product Tests Specific 2.6
       #  run: presto-product-tests/bin/run_on_docker.sh singlenode-kerberos-hdfs-impersonation-with-wire-encryption -g storage_formats,cli,hdfs_impersonation,authorization
       - name: Product Tests Specific 2.7
+        env:
+          OVERRIDE_JDK_DIR: ${{ env.JAVA_HOME }}
         run: presto-product-tests/bin/run_on_docker.sh singlenode-kafka -g kafka
       - name: Product Tests Specific 2.8
+        env:
+          OVERRIDE_JDK_DIR: ${{ env.JAVA_HOME }}
         run: presto-product-tests/bin/run_on_docker.sh singlenode-sqlserver -g sqlserver
diff --git a/.github/workflows/singlestore-tests.yml b/.github/workflows/singlestore-tests.yml
@@ -30,13 +30,17 @@ jobs:
             codechange:
               - '!presto-docs/**'
   singlestore-dockerized-tests:
+    strategy:
+      fail-fast: false
+      matrix:
+        java: [ 8, 17.0.13 ]
     runs-on: ubuntu-latest
     needs: changes
     if: needs.changes.outputs.codechange == 'true'
 
     timeout-minutes: 30
     concurrency:
-      group: ${{ github.workflow }}-singlestore-dockerized-tests-${{ github.event.pull_request.number }}
+      group: ${{ github.workflow }}-singlestore-dockerized-tests-${{ github.event.pull_request.number }}-${{ matrix.java }}
       cancel-in-progress: true
     steps:
       - uses: actions/checkout@v4
@@ -56,7 +60,7 @@ jobs:
       - uses: actions/setup-java@v4
         with:
           distribution: 'temurin'
-          java-version: 8
+          java-version: ${{ matrix.java }}
           cache: 'maven'
       - name: Download nodejs to maven cache
         run: .github/bin/download_nodejs

diff --git a/.github/workflows/spark-integration.yml b/.github/workflows/spark-integration.yml
@@ -30,12 +30,16 @@ jobs:
           codechange:
             - '!presto-docs/**'
   spark-integration:
+    strategy:
+      fail-fast: false
+      matrix:
+        java: [ 8, 17.0.13 ]
     runs-on: ubuntu-latest
     needs: changes
     if: needs.changes.outputs.codechange == 'true'
     timeout-minutes: 60
     concurrency:
-      group: ${{ github.workflow }}-spark-integration-${{ github.event.pull_request.number }}
+      group: ${{ github.workflow }}-spark-integration-${{ github.event.pull_request.number }}-${{ matrix.java }}
       cancel-in-progress: true
     steps:
       - uses: actions/checkout@v4
@@ -44,7 +48,7 @@ jobs:
       - uses: actions/setup-java@v4
         with:
           distribution: 'temurin'
-          java-version: 8
+          java-version: ${{ matrix.java }}
           cache: 'maven'
       - name: Download nodejs to maven cache
         run: .github/bin/download_nodejs

diff --git a/.github/workflows/test-other-modules.yml b/.github/workflows/test-other-modules.yml
@@ -30,12 +30,16 @@ jobs:
           codechange:
             - '!presto-docs/**'
   test-other-modules:
+    strategy:
+      fail-fast: false
+      matrix:
+        java: [ 8, 17.0.13 ]
     runs-on: ubuntu-latest
     needs: changes
     if: needs.changes.outputs.codechange == 'true'
     timeout-minutes: 60
     concurrency:
-      group: ${{ github.workflow }}-test-other-modules-${{ github.event.pull_request.number }}
+      group: ${{ github.workflow }}-test-other-modules-${{ github.event.pull_request.number }}-${{ matrix.java }}
       cancel-in-progress: true
     steps:
       - uses: actions/checkout@v4
@@ -44,7 +48,7 @@ jobs:
       - uses: actions/setup-java@v4
         with:
           distribution: 'temurin'
-          java-version: 8
+          java-version: ${{ matrix.java }}
           cache: 'maven'
       - name: Download nodejs to maven cache
         run: .github/bin/download_nodejs