Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify library dependencies in library.properties #122

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

per1234
Copy link

@per1234 per1234 commented Jan 5, 2020

Specifying the library dependencies in the depends field of library.properties causes the Arduino Library Manager (Arduino IDE 1.8.10 and newer) to offer to install any missing dependencies during installation of this library.

arduino-cli lib install will automatically install the dependencies (arduino-cli 0.7.0 and newer).

Reference:
https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification#libraryproperties-file-format

Specifying the library dependencies in the depends field of library.properties causes the Arduino Library Manager (Arduino IDE 1.8.10 and newer) to offer to install any missing dependencies during installation of this library. "arduino-cli lib install" will automatically install the dependencies (arduino-cli 0.7.0 and newer).
@prenticedavid
Copy link
Owner

Yes, the class depends on Adafruit_GFX.
Adafruit_GFX is very straightforward. Likewise Adafruit_GFX_Button class that comes with Adafruit_GFX.

The "problem" is Adafruit_SPITFT which is bundled with each Adafruit_GFX release.
Adafruit_SPITFT is not used by MCUFRIEND_kbv but is used by most Adafruit hardware classes.

Adafruit like to b*gger up all their existing code with each new Adafruit_SPITFT version.

If I force the Library Manager to upgrade Adafruit_GFX it will affect any Adafruit hardware classes e.g. Adafruit_ST7735, Adafruit_SSD1351, Adafruit_ILI9341, ...
If I just "suggest" the dependency, MCUFRIEND_kbv will work quite happily with all Adafruit_GFX versions.

David.

@per1234
Copy link
Author

per1234 commented Jan 8, 2020

OK, I understand. Should I close this?

@prenticedavid
Copy link
Owner

It is an excellent idea to specify Adafruit_GFX as a dependent library.

Meanwhile, I don't want to be responsible for breaking Adafruit hardware libraries by inflicting a freshly f*cked Adafruit_SPITFT on users that did not ask for changes to their specific Adafruit_hardware library.

If and when Adafruit improve the "features" of Adafruit_SPITFT it would be safe.

David.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants