Skip to content

Commit

Permalink
Merge pull request #4 from pregress/azurerm_storage_account_tls_versi…
Browse files Browse the repository at this point in the history
…on_test

azurerm_storage_account_tls_version_test
  • Loading branch information
pregress authored Oct 31, 2024
2 parents 7b608e3 + 859d7e8 commit 44f30e3
Show file tree
Hide file tree
Showing 2 changed files with 57 additions and 2 deletions.
2 changes: 0 additions & 2 deletions rules/azurerm_storage_account_tls_version.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// This file generated by `tools/apispec-rule-gen/main.go`. DO NOT EDIT

package rules

import (
Expand Down
57 changes: 57 additions & 0 deletions rules/azurerm_storage_account_tls_version_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
package rules

import (
"testing"

hcl "github.com/hashicorp/hcl/v2"
"github.com/terraform-linters/tflint-plugin-sdk/helper"
)

func Test_AzurermStorageAccountUnsecureTls(t *testing.T) {
tests := []struct {
Name string
Content string
Expected helper.Issues
}{
{
Name: "insecure TLS version found",
Content: `
resource "azurerm_storage_account" "example" {
min_tls_version = "TLS1_0"
}`,
Expected: helper.Issues{
{
Rule: NewAzurermStorageAccountUnsecureTls(),
Message: `"TLS1_0" is an insecure value as min_tls_version`,
Range: hcl.Range{
Filename: "resource.tf",
Start: hcl.Pos{Line: 3, Column: 23},
End: hcl.Pos{Line: 3, Column: 31},
},
},
},
},
{
Name: "secure TLS version",
Content: `
resource "azurerm_storage_account" "example" {
min_tls_version = "TLS1_2"
}`,
Expected: helper.Issues{},
},
}

rule := NewAzurermStorageAccountUnsecureTls()

for _, test := range tests {
t.Run(test.Name, func(t *testing.T) {
runner := helper.TestRunner(t, map[string]string{"resource.tf": test.Content})

if err := rule.Check(runner); err != nil {
t.Fatalf("Unexpected error occurred: %s", err)
}

helper.AssertIssues(t, test.Expected, runner.Issues)
})
}
}

0 comments on commit 44f30e3

Please sign in to comment.