Skip to content

Commit

Permalink
rename Dependencies::conditional_requirement to Dependencies::requi…
Browse files Browse the repository at this point in the history
…rement`
  • Loading branch information
prsabahrami committed Jan 24, 2025
1 parent 286801b commit 2155d6b
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 11 deletions.
6 changes: 3 additions & 3 deletions cpp/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ pub struct Dependencies {
/// A pointer to the first element of a list of requirements. Requirements
/// defines which packages should be installed alongside the depending
/// package and the constraints applied to the package.
pub conditional_requirements: Vector<ConditionalRequirement>,
pub requirements: Vector<ConditionalRequirement>,

/// Defines additional constraints on packages that may or may not be part
/// of the solution. Different from `requirements`, packages in this set
Expand Down Expand Up @@ -548,8 +548,8 @@ impl<'d> resolvo::DependencyProvider for &'d DependencyProvider {
};

resolvo::Dependencies::Known(KnownDependencies {
conditional_requirements: dependencies
.conditional_requirements
requirements: dependencies
.requirements
.into_iter()
.map(Into::into)
.collect(),
Expand Down
2 changes: 1 addition & 1 deletion src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ pub struct KnownDependencies {
feature = "serde",
serde(default, skip_serializing_if = "Vec::is_empty")
)]
pub conditional_requirements: Vec<ConditionalRequirement>,
pub requirements: Vec<ConditionalRequirement>,

/// Defines additional constraints on packages that may or may not be part
/// of the solution. Different from `requirements`, packages in this set
Expand Down
2 changes: 1 addition & 1 deletion src/snapshot.rs
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ impl DependencySnapshot {
}
}

for &req in deps.conditional_requirements.iter() {
for &req in deps.requirements.iter() {
let (_, requirement) = req.into_condition_and_requirement(); // TODO: condition

match requirement {
Expand Down
8 changes: 4 additions & 4 deletions src/solver/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1643,7 +1643,7 @@ async fn add_clauses_for_solvables<D: DependencyProvider>(
ready(Ok(TaskResult::Dependencies {
solvable_id: solvable_or_root,
dependencies: Dependencies::Known(KnownDependencies {
conditional_requirements: root_requirements.to_vec(),
requirements: root_requirements.to_vec(),
constrains: root_constraints.to_vec(),
}),
}))
Expand Down Expand Up @@ -1676,7 +1676,7 @@ async fn add_clauses_for_solvables<D: DependencyProvider>(
};

let (conditional_requirements, constrains) = match dependencies {
Dependencies::Known(deps) => (deps.conditional_requirements, deps.constrains),
Dependencies::Known(deps) => (deps.requirements, deps.constrains),
Dependencies::Unknown(reason) => {
// There is no information about the solvable's dependencies, so we add
// an exclusion clause for it
Expand Down Expand Up @@ -1926,12 +1926,12 @@ async fn add_clauses_for_solvables<D: DependencyProvider>(
);

Check warning on line 1926 in src/solver/mod.rs

View workflow job for this annotation

GitHub Actions / Format and Lint

Diff in /home/runner/work/resolvo/resolvo/src/solver/mod.rs
}


if let Some((condition, condition_candidates)) = condition {
tracing::trace!(
"Adding conditional clauses for {} with condition {}",
requirement.display(cache.provider()),

Check warning on line 1933 in src/solver/mod.rs

View workflow job for this annotation

GitHub Actions / Format and Lint

Diff in /home/runner/work/resolvo/resolvo/src/solver/mod.rs
std::convert::Into::<Requirement>::into(condition)
.display(cache.provider()),
std::convert::Into::<Requirement>::into(condition).display(cache.provider()),
);

let condition_version_set_variables = requirement_to_sorted_candidates.insert(
Expand Down
4 changes: 2 additions & 2 deletions tests/solver.rs
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,7 @@ impl DependencyProvider for BundleBoxProvider {
};

let mut result = KnownDependencies {
conditional_requirements: Vec::with_capacity(deps.dependencies.len()),
requirements: Vec::with_capacity(deps.dependencies.len()),
constrains: Vec::with_capacity(deps.constrains.len()),
};
for req in &deps.dependencies {
Expand Down Expand Up @@ -515,7 +515,7 @@ impl DependencyProvider for BundleBoxProvider {
};

result
.conditional_requirements
.requirements
.push(ConditionalRequirement {
requirement,
condition: None,
Expand Down

0 comments on commit 2155d6b

Please sign in to comment.