-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add concurreny
configuration
#2569
Merged
ruben-arts
merged 12 commits into
prefix-dev:main
from
ruben-arts:feat/configure_max_concurrent_solves
Nov 28, 2024
Merged
feat: add concurreny
configuration
#2569
ruben-arts
merged 12 commits into
prefix-dev:main
from
ruben-arts:feat/configure_max_concurrent_solves
Nov 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it trickle down to the update builder
Should we add a |
max_concurrent_solves
configurationconcurreny
configuration
Thanks! I closed the other one :) |
wolfv
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
jjjermiah
pushed a commit
to jjjermiah/pixi
that referenced
this pull request
Nov 30, 2024
### Why Pixi can possibly use a big amount of memory during the solve or network requests during the repodata fetching. While we search for a better/automated solution we want to let the user escape the issue by forcing the amount of concurrent jobs. The related issue is: prefix-dev#2458 ### What this PR adds As a user you can now define the max concurrent solves and max network requests in two ways **CLI** ``` pixi install --concurrent-solves 3 pixi install --concurrent-downloads 12 ``` **configuration** ``` pixi config set concurrency.solves 1 pixi config set concurrency.downloads 12 ``` `config.toml` ```toml [concurrency] solves = 2 downloads = 12 ``` ### TODO: After initial approval of design I'll add the following: - [x] : Add documentation - [x] : Add basic cli and configuration test to the integration tests
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Pixi can possibly use a big amount of memory during the solve or network requests during the repodata fetching. While we search for a better/automated solution we want to let the user escape the issue by forcing the amount of concurrent jobs.
The related issue is: #2458
What this PR adds
As a user you can now define the max concurrent solves and max network requests in two ways
CLI
configuration
config.toml
TODO:
After initial approval of design I'll add the following: