Rename executables #131
Rename executables #131
Conversation
CMakeLists.txt
Outdated
| file(COPY ${CMAKE_CURRENT_SOURCE_DIR}/src/vtk_calculator.py DESTINATION ${CMAKE_CURRENT_BINARY_DIR}) | ||
| file(COPY ${CMAKE_CURRENT_SOURCE_DIR}/src/precice-aste-partition.py DESTINATION ${CMAKE_CURRENT_BINARY_DIR}) | ||
| file(COPY ${CMAKE_CURRENT_SOURCE_DIR}/src/precice-aste-join.py DESTINATION ${CMAKE_CURRENT_BINARY_DIR}) | ||
| file(COPY ${CMAKE_CURRENT_SOURCE_DIR}/src/precice-aste-evaluate.py DESTINATION ${CMAKE_CURRENT_BINARY_DIR}) |
There was a problem hiding this comment.
Do we have to keep the .py extension or can we omit it?
There was a problem hiding this comment.
We can omit them. Probably the best way is to keep them in the source folder but install them without extension.
Those scripts are executed by /usr/bin/env python3 as long as python3 is installed, I should be safe.
There was a problem hiding this comment.
Probably the best way is to keep them in the source folder but install them without extension.
Why?
There was a problem hiding this comment.
The developers can easily recognize the files from the extension. Removing the extension from the source file just makes it harder to understand I don't see any benefit. On the other hand, it does not matter whether it is a script file or binary executable for the user. Removing extension makes it closer to the "usual" executable experience.
There was a problem hiding this comment.
I would not want have differences between the source code version and the build tree version. Let's go without the extension.
There was a problem hiding this comment.
It is ready to merge.
* Exit on error in run all script * Remove redirection * Run all cases and exit * Fix syntax; Move sh to bash * Add missing parantesis * Update tests/example/run-all.sh Co-authored-by: David Schneider <[email protected]> * Update tests/example/run-all.sh Co-authored-by: David Schneider <[email protected]> Co-authored-by: David Schneider <[email protected]>
Change the name of executables according to #83