-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alkimi: Add imp extension support #4213
Open
kalidas-alkimi
wants to merge
111
commits into
prebid:master
Choose a base branch
from
Alkimi-Exchange:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+15
−10
Open
Changes from all commits
Commits
Show all changes
111 commits
Select commit
Hold shift + click to select a range
4ea2865
Added Alkimi adapter on PBS-GO
kalidas-alkimi 948a653
added jenkinsfile
abalalaev bdca1b3
added tests to jenkinsfile
abalalaev 36b8b23
fixed alkimi.yaml
abalalaev deae80d
changed alkimi.yaml
abalalaev 8c247a9
added pbs.yaml
abalalaev 68228ca
added deploy to dev stage
abalalaev e7346da
changed jenkinsfile
abalalaev 2beae76
changed jenkinsfile
abalalaev fbd031e
ExtImpAlkimi fix
pro-nsk 8aed78b
ExtImpAlkimi fix
pro-nsk f5507f3
fix test
pro-nsk a189059
ExtImpAlkimi fix
pro-nsk 988f4e6
ExtImpAlkimi fix
pro-nsk b8efa58
ExtImpAlkimi fix
pro-nsk 27f8ac6
ExtImpAlkimi fix
pro-nsk 7e2f882
fix test
pro-nsk 6ebce23
fix test
pro-nsk 6b4bd1b
fix test
pro-nsk 976ef20
fix test
pro-nsk 6072024
fix test
pro-nsk c3d0f4c
fix test
pro-nsk 9460013
ExtImpAlkimi fix
pro-nsk dc84584
fix test
pro-nsk d190a7a
ExtImpAlkimi fix
pro-nsk 415e22b
ExtImpAlkimi fix
pro-nsk 99c748f
ExtImpAlkimi fix
pro-nsk 9a02f7c
ExtImpAlkimi fix
pro-nsk dde6833
fix test
pro-nsk 3041a86
fix test
pro-nsk cf71f24
Imp structure updated
kalidas-alkimi b0a394c
Renamed the Imp structure
kalidas-alkimi 2cba27d
Merge branch 'master' of github.com:prebid/prebid-server into prebid-…
pro-nsk 340d938
Merge master
pro-nsk 5811110
Update alkimi adapter on adapters_builders.go file
kalidas-alkimi 0a93d0f
Merge branch 'master' into master_asterio
pro-nsk 9597943
prebid server v2
pro-nsk f8bb73b
prebid server v2
pro-nsk 73f72d2
Updated imports according to prebid-server v2
kalidas-alkimi eeb5cfd
Merge branch 'master' into master_asterio
pro-nsk 0a1e41f
update alkimi adapter
pro-nsk 5cd75fc
update alkimi adapter
pro-nsk 95aea05
update alkimi adapter
pro-nsk f5cc7b3
update alkimi adapter
pro-nsk 254642e
Update alkimi adapter according to review
kalidas-alkimi 3be547c
Merge branch 'master' into master_asterio
pro-nsk 773bf92
Removed tab spaces
kalidas-alkimi 1f9a2b8
Merge branch 'master' into master_asterio
pro-nsk 7b637d5
unit tests
pro-nsk 38690af
bid count fix
pro-nsk 467a6e5
make bids fix
pro-nsk ed8e9a2
fix test
pro-nsk b0fb125
fix test
pro-nsk 33ed0c0
fix test
pro-nsk 0a3f19c
fix test
pro-nsk 3522adc
fix test
pro-nsk 87a2333
Updated the review comments
kalidas-alkimi f25134d
Merge branch 'master' into master_asterio
pro-nsk adeeede
fixes
pro-nsk 4013eb5
fix test
pro-nsk f970b00
Changes for the review
kalidas-alkimi d717a33
JSON tests
pro-nsk 24b83de
JSON tests
pro-nsk 1c58cff
JSON tests
pro-nsk 39850c1
JSON tests
pro-nsk 6e0b269
JSON tests
pro-nsk 6bc2d7f
JSON tests
pro-nsk f4581e2
JSON tests
pro-nsk e31ac96
JSON tests
pro-nsk 0363693
JSON tests
pro-nsk f2f04f0
JSON tests
pro-nsk 6d2b1a1
JSON tests
pro-nsk 5bee0c6
JSON tests
pro-nsk 9b23941
JSON tests
pro-nsk bc3f1f6
JSON tests
pro-nsk f4cb595
JSON tests
pro-nsk 2956753
JSON tests
pro-nsk 88735d4
JSON tests
pro-nsk c0e6e10
JSON tests
pro-nsk 857a8dc
JSON tests
pro-nsk 70f5518
JSON tests
pro-nsk 48348c5
JSON tests
pro-nsk e9a81b3
JSON tests
pro-nsk 0aede9d
JSON tests
pro-nsk 4c40256
JSON tests
pro-nsk cff0982
JSON tests
pro-nsk cee8706
JSON tests
pro-nsk 4b5c779
JSON tests
pro-nsk c39d1cb
JSON tests added
pro-nsk 46a764d
imports fixed
pro-nsk be64f7b
Merge branch 'master' into master_asterio
pro-nsk 681a034
tests fixed
pro-nsk 325861d
tests fixed
pro-nsk e77d00c
tests fixed
pro-nsk c3fe4cc
remove unnecessary tests
pro-nsk 39a5b97
Merge branch 'master' into master_asterio
pro-nsk 1e6bfdc
tests fixed
pro-nsk e90c6d3
tests fixed
pro-nsk 4541d7e
tests fixed
pro-nsk 2d298c2
Merge pull request #2 from prebid/master
pro-nsk 59a1a87
Merge branch 'master_asterio' into master
pro-nsk 7530153
Added User sync url for Alkimi adapter
kalidas-alkimi 4ad7bd0
revert changes
pro-nsk da32542
fix user-sync url
pro-nsk c7e0320
Updated the user sync url to prod env instead of dev env
kalidas-alkimi 50a999a
Merge branch 'master' of https://github.com/Alkimi-Exchange/prebid-se…
kalidas-alkimi 92509c8
Merge branch 'master' of github.com:prebid/prebid-server into prebid-…
pro-nsk f3d1eac
Merge branch 'prebid-master2'
pro-nsk 055866e
Merge pull request #6 from prebid/master
pro-nsk 9b60ac7
Added support for Imp extention object
kalidas-alkimi 9406a5c
Updated the jsonutil
kalidas-alkimi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is imp.ID required to be part of impression extension as this is standard ORTB parameter ?
Usually bidder specific custom parameters are added in impression extension.
When bidder receive request, imp.ID can be used as AdUnitCode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's required for bidder.
But this is not related to this PR, in this PR we've added support of any parameters in imp.ext map.